From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: In the pg_upgrade test suite, don't write to src/test/regress.
Date: Tue, 28 May 2019 20:09:20 +0000
Message-ID: <E1hViPQ-0005wU-L7@gemulon.postgresql.org> (raw)
In the pg_upgrade test suite, don't write to src/test/regress.
When this suite runs installcheck, redirect file creations from
src/test/regress to src/bin/pg_upgrade/tmp_check/regress. This closes a
race condition in "make -j check-world". If the pg_upgrade suite wrote
to a given src/test/regress/results file in parallel with the regular
src/test/regress invocation writing it, a test failed spuriously. Even
without parallelism, in "make -k check-world", the suite finishing
second overwrote the other's regression.diffs. This revealed test
"largeobject" assuming @abs_builddir@ is getcwd(), so fix that, too.
Buildfarm client REL_10, released fifty-four days ago, supports saving
regression.diffs from its new location. When an older client reports a
pg_upgradeCheck failure, it will no longer include regression.diffs.
Back-patch to 9.5, where pg_upgrade moved to src/bin.
Reviewed (in earlier versions) by Andrew Dunstan.
Discussion: https://postgr.es/m/20181224034411.GA3224776@rfd.leadboat.com
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/c44e9bc3a10f8c6dff07db355375339d7a6db24b
Modified Files
--------------
src/bin/pg_upgrade/test.sh | 11 +++++++++++
src/test/regress/input/largeobject.source | 6 +++---
src/test/regress/output/largeobject.source | 6 +++---
src/test/regress/output/largeobject_1.source | 6 +++---
src/tools/msvc/vcregress.pl | 21 ++++++++++++++++++---
5 files changed, 38 insertions(+), 12 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: noah@leadboat.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: In the pg_upgrade test suite, don't write to src/test/regress.
In-Reply-To: <E1hViPQ-0005wU-L7@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox