pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix progress reporting of CLUSTER / VACUUM FULL
Date: Fri, 13 Sep 2019 17:58:56 +0000
Message-ID: <E1i8pqS-0003NN-7p@gemulon.postgresql.org> (raw)

Fix progress reporting of CLUSTER / VACUUM FULL

The progress state was being clobbered once the first index completed
being rebuilt, causing the final phases of the operation not show
anything in the progress view.  This was inadvertently broken in
03f9e5cba0ee, which added progress tracking for REINDEX.

(The reason this bugfix is this small is that I had already noticed this
problem when writing monitoring for CREATE INDEX, and had already worked
around it, as can be seen in discussion starting at
https://postgr.es/m/20190329150218.GA25010@alvherre.pgsql Fixing the
problem is just a matter of fixing one place touched by the REINDEX
monitoring.)

Reported by: Álvaro Herrera
Author: Álvaro Herrera
Discussion: https://postgr.es/m/20190801184333.GA21369@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6212276e4343f729b0152e81824f850d1a21d57e

Modified Files
--------------
src/backend/catalog/index.c      | 24 +++++++++++++++---------
src/backend/commands/indexcmds.c |  4 ++--
src/include/nodes/parsenodes.h   |  1 +
3 files changed, 18 insertions(+), 11 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1i8pqS-0003NN-7p@gemulon.postgresql.org>
Permalink:  ../E1i8pqS-0003NN-7p@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1i8pqS-0003NN-7p@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix progress reporting of CLUSTER / VACUUM FULL
  In-Reply-To: <E1i8pqS-0003NN-7p@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox