pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION. 7+ messages / 1 participants [nested] [flat]
* pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION. @ 2019-11-08 08:15 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Etsuro Fujita @ 2019-11-08 08:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix error message for PREPARE TRANSACTION. Currently, postgres_fdw does not support preparing a remote transaction for two-phase commit even in the case where the remote transaction is read-only, but the old error message appeared to imply that that was not supported only if the remote transaction modified remote tables. Change the message so as to include the case where the remote transaction is read-only. Also fix a comment above the message. Also add a note about the lack of supporting PREPARE TRANSACTION to the postgres_fdw documentation. Reported-by: Gilles Darold Author: Gilles Darold and Etsuro Fujita Reviewed-by: Michael Paquier and Kyotaro Horiguchi Backpatch-through: 9.4 Discussion: https://postgr.es/m/08600ed3-3084-be70-65ba-279ab19618a5%40darold.net Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/879c1176157175e0a83742b810f137aebccef4a4 Modified Files -------------- contrib/postgres_fdw/connection.c | 16 ++++++++-------- doc/src/sgml/postgres-fdw.sgml | 6 ++++++ 2 files changed, 14 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION. @ 2019-11-08 08:15 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Etsuro Fujita @ 2019-11-08 08:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix error message for PREPARE TRANSACTION. Currently, postgres_fdw does not support preparing a remote transaction for two-phase commit even in the case where the remote transaction is read-only, but the old error message appeared to imply that that was not supported only if the remote transaction modified remote tables. Change the message so as to include the case where the remote transaction is read-only. Also fix a comment above the message. Also add a note about the lack of supporting PREPARE TRANSACTION to the postgres_fdw documentation. Reported-by: Gilles Darold Author: Gilles Darold and Etsuro Fujita Reviewed-by: Michael Paquier and Kyotaro Horiguchi Backpatch-through: 9.4 Discussion: https://postgr.es/m/08600ed3-3084-be70-65ba-279ab19618a5%40darold.net Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0cc31cc32da0ff6b3569eb73249eb1549b8731d1 Modified Files -------------- contrib/postgres_fdw/connection.c | 16 ++++++++-------- doc/src/sgml/postgres-fdw.sgml | 6 ++++++ 2 files changed, 14 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION. @ 2019-11-08 08:15 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Etsuro Fujita @ 2019-11-08 08:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix error message for PREPARE TRANSACTION. Currently, postgres_fdw does not support preparing a remote transaction for two-phase commit even in the case where the remote transaction is read-only, but the old error message appeared to imply that that was not supported only if the remote transaction modified remote tables. Change the message so as to include the case where the remote transaction is read-only. Also fix a comment above the message. Also add a note about the lack of supporting PREPARE TRANSACTION to the postgres_fdw documentation. Reported-by: Gilles Darold Author: Gilles Darold and Etsuro Fujita Reviewed-by: Michael Paquier and Kyotaro Horiguchi Backpatch-through: 9.4 Discussion: https://postgr.es/m/08600ed3-3084-be70-65ba-279ab19618a5%40darold.net Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/042e82cef949b3d0acf04431c25e7ee0e1535456 Modified Files -------------- contrib/postgres_fdw/connection.c | 16 ++++++++-------- doc/src/sgml/postgres-fdw.sgml | 6 ++++++ 2 files changed, 14 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION. @ 2019-11-08 08:15 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Etsuro Fujita @ 2019-11-08 08:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix error message for PREPARE TRANSACTION. Currently, postgres_fdw does not support preparing a remote transaction for two-phase commit even in the case where the remote transaction is read-only, but the old error message appeared to imply that that was not supported only if the remote transaction modified remote tables. Change the message so as to include the case where the remote transaction is read-only. Also fix a comment above the message. Also add a note about the lack of supporting PREPARE TRANSACTION to the postgres_fdw documentation. Reported-by: Gilles Darold Author: Gilles Darold and Etsuro Fujita Reviewed-by: Michael Paquier and Kyotaro Horiguchi Backpatch-through: 9.4 Discussion: https://postgr.es/m/08600ed3-3084-be70-65ba-279ab19618a5%40darold.net Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0c7a28a5eabd9869a3af9ca3c0360a043438f865 Modified Files -------------- contrib/postgres_fdw/connection.c | 16 ++++++++-------- doc/src/sgml/postgres-fdw.sgml | 6 ++++++ 2 files changed, 14 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION. @ 2019-11-08 08:15 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Etsuro Fujita @ 2019-11-08 08:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix error message for PREPARE TRANSACTION. Currently, postgres_fdw does not support preparing a remote transaction for two-phase commit even in the case where the remote transaction is read-only, but the old error message appeared to imply that that was not supported only if the remote transaction modified remote tables. Change the message so as to include the case where the remote transaction is read-only. Also fix a comment above the message. Also add a note about the lack of supporting PREPARE TRANSACTION to the postgres_fdw documentation. Reported-by: Gilles Darold Author: Gilles Darold and Etsuro Fujita Reviewed-by: Michael Paquier and Kyotaro Horiguchi Backpatch-through: 9.4 Discussion: https://postgr.es/m/08600ed3-3084-be70-65ba-279ab19618a5%40darold.net Branch ------ REL9_6_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/bca0aed2d01ce50e2f7be14c97f80118b0f67952 Modified Files -------------- contrib/postgres_fdw/connection.c | 16 ++++++++-------- doc/src/sgml/postgres-fdw.sgml | 6 ++++++ 2 files changed, 14 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION. @ 2019-11-08 08:15 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Etsuro Fujita @ 2019-11-08 08:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix error message for PREPARE TRANSACTION. Currently, postgres_fdw does not support preparing a remote transaction for two-phase commit even in the case where the remote transaction is read-only, but the old error message appeared to imply that that was not supported only if the remote transaction modified remote tables. Change the message so as to include the case where the remote transaction is read-only. Also fix a comment above the message. Also add a note about the lack of supporting PREPARE TRANSACTION to the postgres_fdw documentation. Reported-by: Gilles Darold Author: Gilles Darold and Etsuro Fujita Reviewed-by: Michael Paquier and Kyotaro Horiguchi Backpatch-through: 9.4 Discussion: https://postgr.es/m/08600ed3-3084-be70-65ba-279ab19618a5%40darold.net Branch ------ REL9_5_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b260ce9c19b64e0430d89f8cc586fc8f6df5ee07 Modified Files -------------- contrib/postgres_fdw/connection.c | 16 ++++++++-------- doc/src/sgml/postgres-fdw.sgml | 6 ++++++ 2 files changed, 14 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION. @ 2019-11-08 08:15 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Etsuro Fujita @ 2019-11-08 08:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix error message for PREPARE TRANSACTION. Currently, postgres_fdw does not support preparing a remote transaction for two-phase commit even in the case where the remote transaction is read-only, but the old error message appeared to imply that that was not supported only if the remote transaction modified remote tables. Change the message so as to include the case where the remote transaction is read-only. Also fix a comment above the message. Also add a note about the lack of supporting PREPARE TRANSACTION to the postgres_fdw documentation. Reported-by: Gilles Darold Author: Gilles Darold and Etsuro Fujita Reviewed-by: Michael Paquier and Kyotaro Horiguchi Backpatch-through: 9.4 Discussion: https://postgr.es/m/08600ed3-3084-be70-65ba-279ab19618a5%40darold.net Branch ------ REL9_4_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1bd67d5358435e4441961d250a408979f0c4f484 Modified Files -------------- contrib/postgres_fdw/connection.c | 16 ++++++++-------- doc/src/sgml/postgres-fdw.sgml | 6 ++++++ 2 files changed, 14 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2019-11-08 08:15 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2019-11-08 08:15 pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION. Etsuro Fujita <efujita@postgresql.org> 2019-11-08 08:15 pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION. Etsuro Fujita <efujita@postgresql.org> 2019-11-08 08:15 pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION. Etsuro Fujita <efujita@postgresql.org> 2019-11-08 08:15 pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION. Etsuro Fujita <efujita@postgresql.org> 2019-11-08 08:15 pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION. Etsuro Fujita <efujita@postgresql.org> 2019-11-08 08:15 pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION. Etsuro Fujita <efujita@postgresql.org> 2019-11-08 08:15 pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION. Etsuro Fujita <efujita@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox