From: Etsuro Fujita <efujita@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION.
Date: Fri, 08 Nov 2019 08:15:27 +0000
Message-ID: <E1iSzQV-0001YR-Ji@gemulon.postgresql.org> (raw)
postgres_fdw: Fix error message for PREPARE TRANSACTION.
Currently, postgres_fdw does not support preparing a remote transaction
for two-phase commit even in the case where the remote transaction is
read-only, but the old error message appeared to imply that that was not
supported only if the remote transaction modified remote tables. Change
the message so as to include the case where the remote transaction is
read-only.
Also fix a comment above the message.
Also add a note about the lack of supporting PREPARE TRANSACTION to the
postgres_fdw documentation.
Reported-by: Gilles Darold
Author: Gilles Darold and Etsuro Fujita
Reviewed-by: Michael Paquier and Kyotaro Horiguchi
Backpatch-through: 9.4
Discussion: https://postgr.es/m/08600ed3-3084-be70-65ba-279ab19618a5%40darold.net
Branch
------
REL9_5_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/b260ce9c19b64e0430d89f8cc586fc8f6df5ee07
Modified Files
--------------
contrib/postgres_fdw/connection.c | 16 ++++++++--------
doc/src/sgml/postgres-fdw.sgml | 6 ++++++
2 files changed, 14 insertions(+), 8 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: efujita@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION.
In-Reply-To: <E1iSzQV-0001YR-Ji@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox