pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Silence minor compiler warnings. 2+ messages / 1 participants [nested] [flat]
* pgsql: Silence minor compiler warnings. @ 2020-01-19 21:04 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2020-01-19 21:04 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Silence minor compiler warnings. Ensure that ClassifyUtilityCommandAsReadOnly() has defined behavior even if TransactionStmt.kind has a value that's not one of the declared values for its enum. Suppress warnings from compilers that don't know that elog(ERROR) doesn't return, in ClassifyUtilityCommandAsReadOnly() and jsonb_set_lax(). Per Coverity and buildfarm. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/9c679a08f0cdedcf7f084daea3cba6ae9c3cbced Modified Files -------------- src/backend/tcop/utility.c | 9 ++++++--- src/backend/utils/adt/jsonfuncs.c | 1 + 2 files changed, 7 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Silence minor compiler warnings. @ 2022-02-13 18:25 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2022-02-13 18:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Silence minor compiler warnings. Depending on compiler version and optimization level, we might get a complaint that lazy_scan_heap's "freespace" is used uninitialized. Compilers not aware that ereport(ERROR) doesn't return complained about bbsink_lz4_new(). Assigning "-1" to a uint64 value has unportable results; fortunately, the value of xlogreadsegno is unimportant when xlogreadfd is -1. (It looks to me like there is no need for xlogreadsegno to be static in the first place, but I didn't venture to change that.) Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/302612a6c74fb16f26d094ff47e9c59cf412740c Modified Files -------------- src/backend/access/heap/vacuumlazy.c | 2 +- src/backend/replication/basebackup_lz4.c | 1 + src/bin/pg_rewind/parsexlog.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-02-13 18:25 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-01-19 21:04 pgsql: Silence minor compiler warnings. Tom Lane <tgl@sss.pgh.pa.us> 2022-02-13 18:25 pgsql: Silence minor compiler warnings. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox