pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Silence minor compiler warnings.
Date: Sun, 13 Feb 2022 18:25:26 +0000
Message-ID: <E1nJJYs-0007GT-GN@gemulon.postgresql.org> (raw)

Silence minor compiler warnings.

Depending on compiler version and optimization level, we might
get a complaint that lazy_scan_heap's "freespace" is used
uninitialized.

Compilers not aware that ereport(ERROR) doesn't return complained
about bbsink_lz4_new().

Assigning "-1" to a uint64 value has unportable results; fortunately,
the value of xlogreadsegno is unimportant when xlogreadfd is -1.
(It looks to me like there is no need for xlogreadsegno to be static
in the first place, but I didn't venture to change that.)

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/302612a6c74fb16f26d094ff47e9c59cf412740c

Modified Files
--------------
src/backend/access/heap/vacuumlazy.c     | 2 +-
src/backend/replication/basebackup_lz4.c | 1 +
src/bin/pg_rewind/parsexlog.c            | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)



view thread (2+ messages)

Message-ID: <E1nJJYs-0007GT-GN@gemulon.postgresql.org>
Permalink:  ../E1nJJYs-0007GT-GN@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nJJYs-0007GT-GN@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Silence minor compiler warnings.
  In-Reply-To: <E1nJJYs-0007GT-GN@gemulon.postgresql.org>
  References: <E1nJJYs-0007GT-GN@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox