pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: pg_waldump: Add a --quiet option.
3+ messages / 3 participants
[nested] [flat]
* pgsql: pg_waldump: Add a --quiet option.
@ 2020-04-03 01:11 Robert Haas <rhaas@postgresql.org>
0 siblings, 1 reply; 3+ messages in thread
From: Robert Haas @ 2020-04-03 01:11 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
pg_waldump: Add a --quiet option.
The primary motivation for this change is that it will be used by the
upcoming patch to add backup manifests, but it also seems to have some
potential more general use.
Andres Freund and Robert Haas
Discussion: http://postgr.es/m/20200330020814.nspra4mvby42yoa4@alap3.anarazel.de
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ac44367efbef198c57a18b96dbc6a39191720994
Modified Files
--------------
doc/src/sgml/ref/pg_waldump.sgml | 12 ++++++++++++
src/bin/pg_waldump/pg_waldump.c | 22 ++++++++++++++++------
2 files changed, 28 insertions(+), 6 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: pg_waldump: Add a --quiet option.
@ 2020-04-03 01:41 Fujii Masao <masao.fujii@oss.nttdata.com>
parent: Robert Haas <rhaas@postgresql.org>
0 siblings, 1 reply; 3+ messages in thread
From: Fujii Masao @ 2020-04-03 01:41 UTC (permalink / raw)
To: Robert Haas <rhaas@postgresql.org>; pgsql-committers@lists.postgresql.org
On 2020/04/03 10:11, Robert Haas wrote:
> pg_waldump: Add a --quiet option.
>
> The primary motivation for this change is that it will be used by the
> upcoming patch to add backup manifests, but it also seems to have some
> potential more general use.
I'm not sure what the actual purpose of this feature yet, but ISTM that
the following change is necessary. Otherwise, "empty" stats information
is output even when --quiet is specified.
- if (config.stats == true)
+ if (config.stats == true && !config.quiet)
XLogDumpDisplayStats(&config, &stats);
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: pg_waldump: Add a --quiet option.
@ 2020-04-03 15:54 Robert Haas <robertmhaas@gmail.com>
parent: Fujii Masao <masao.fujii@oss.nttdata.com>
0 siblings, 0 replies; 3+ messages in thread
From: Robert Haas @ 2020-04-03 15:54 UTC (permalink / raw)
To: Fujii Masao <masao.fujii@oss.nttdata.com>; +Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
On Thu, Apr 2, 2020 at 9:41 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
> On 2020/04/03 10:11, Robert Haas wrote:
> > pg_waldump: Add a --quiet option.
> >
> > The primary motivation for this change is that it will be used by the
> > upcoming patch to add backup manifests, but it also seems to have some
> > potential more general use.
>
> I'm not sure what the actual purpose of this feature yet, but ISTM that
> the following change is necessary. Otherwise, "empty" stats information
> is output even when --quiet is specified.
>
> - if (config.stats == true)
> + if (config.stats == true && !config.quiet)
> XLogDumpDisplayStats(&config, &stats);
Oops. That seems like a bug. It only matters if you specify --quiet
and --stats together, but even so the behavior is not as documented,
so it should be fixed. Thanks.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2020-04-03 15:54 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-04-03 01:11 pgsql: pg_waldump: Add a --quiet option. Robert Haas <rhaas@postgresql.org>
2020-04-03 01:41 ` Fujii Masao <masao.fujii@oss.nttdata.com>
2020-04-03 15:54 ` Robert Haas <robertmhaas@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox