pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Joe Conway <mail@joeconway.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add CHECK_FOR_INTERRUPTS() to the repeat() function
Date: Thu, 28 May 2020 17:20:13 +0000
Message-ID: <E1jeMCT-0006Q7-2f@gemulon.postgresql.org> (raw)

Add CHECK_FOR_INTERRUPTS() to the repeat() function

The repeat() function loops for potentially a long time without
ever checking for interrupts. This prevents, for example, a query
cancel from interrupting until the work is all done. Fix by
inserting a CHECK_FOR_INTERRUPTS() into the loop.

Backpatch to all supported versions.

Discussion: https://www.postgresql.org/message-id/flat/8692553c-7fe8-17d9-cbc1-7cddb758f4c6%40joeconway.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/887cdff4dcbdfbfdbf9a29dfad0edc09c6ec3398

Modified Files
--------------
src/backend/utils/adt/oracle_compat.c | 2 ++
1 file changed, 2 insertions(+)



view thread (6+ messages)  latest in thread

Message-ID: <E1jeMCT-0006Q7-2f@gemulon.postgresql.org>
Permalink:  ../E1jeMCT-0006Q7-2f@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1jeMCT-0006Q7-2f@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: mail@joeconway.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add CHECK_FOR_INTERRUPTS() to the repeat() function
  In-Reply-To: <E1jeMCT-0006Q7-2f@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox