pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove reset of testtablespace from pg_regress on Windows
Date: Thu, 18 Jun 2020 01:40:50 +0000
Message-ID: <E1jljXu-0007fp-Ct@gemulon.postgresql.org> (raw)

Remove reset of testtablespace from pg_regress on Windows

testtablespace is an extra path used as tablespace location in the main
regression test suite, computed from --outputdir as defined by the
caller of pg_regress (current directory if undefined).

This special handling was introduced as of f10589e to be specific to
MSVC, as we let pg_regress' Makefile handle this cleanup in other
environments.  This moves the cleanup to the MSVC script running
regression tests instead where needed: check, installcheck and
upgradecheck.  I have also checked this patch on MSVC with repeated runs
of each target.

Author: Kyotaro Horiguchi, Michael Paquier
Discussion: https://postgr.es/m/20200219.142519.437573253063431435.horikyota.ntt@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2b2a070d98b2f2c7ecc031e582cfefa400316ce3

Modified Files
--------------
src/test/regress/pg_regress.c | 22 ----------------------
src/tools/msvc/vcregress.pl   | 17 +++++++++++++++--
2 files changed, 15 insertions(+), 24 deletions(-)



view thread (5+ messages)  latest in thread

Message-ID: <E1jljXu-0007fp-Ct@gemulon.postgresql.org>
Permalink:  ../E1jljXu-0007fp-Ct@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1jljXu-0007fp-Ct@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove reset of testtablespace from pg_regress on Windows
  In-Reply-To: <E1jljXu-0007fp-Ct@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox