pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Inline the fast path of plpgsql's exec_cast_value().
Date: Sun, 05 Jul 2020 17:12:39 +0000
Message-ID: <E1js8Bz-0003hK-MI@gemulon.postgresql.org> (raw)

Inline the fast path of plpgsql's exec_cast_value().

In the common case where this function isn't actually asked to perform
any type conversion, there's nothing it has to do beyond comparing the
arguments.  Arrange for that part to be inlined into callers, with the
slower path remaining out-of-line.  This seems to be good for several
percent speedup on simple cases, with only minimal code bloat.

Amit Khandekar

Discussion: https://postgr.es/m/CAJ3gD9eBNrmUD7WBBLG8ohaZ485H9y+4eihQTgr+K8Lhka3vcQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fe2e206cdb00a2d5dcebc3c8e8119017392d9781

Modified Files
--------------
src/pl/plpgsql/src/pl_exec.c | 65 +++++++++++++++++++++++++++++---------------
1 file changed, 43 insertions(+), 22 deletions(-)



Message-ID: <E1js8Bz-0003hK-MI@gemulon.postgresql.org>
Permalink:  ../E1js8Bz-0003hK-MI@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1js8Bz-0003hK-MI@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Inline the fast path of plpgsql's exec_cast_value().
  In-Reply-To: <E1js8Bz-0003hK-MI@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox