pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix compiler warning
Date: Tue, 15 Sep 2020 03:09:17 +0000
Message-ID: <E1kI1LJ-0000SI-OH@gemulon.postgresql.org> (raw)

Fix compiler warning

Introduced in 0aa8f7640.

MSVC warned about performing 32-bit bit shifting when it appeared like we
might like a 64-bit result.  We did, but it just so happened that none of
the calls to this function could have caused the 32-bit shift to overflow.

Here we just cast the constant to int64 to make the compiler happy.

Discussion: https://postgr.es/m/CAApHDvofA_vsrpC13mq_hZyuye5B-ssKEaer04OouXYCO5-uXQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fe4f36bcde182d57dee5dba898076aba5d826515

Modified Files
--------------
src/backend/utils/adt/dbsize.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



view thread (30+ messages)  latest in thread

Message-ID: <E1kI1LJ-0000SI-OH@gemulon.postgresql.org>
Permalink:  ../E1kI1LJ-0000SI-OH@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1kI1LJ-0000SI-OH@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix compiler warning
  In-Reply-To: <E1kI1LJ-0000SI-OH@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox