agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add pg_nodiscard decorations to some functions
Date: Wed, 11 Nov 2020 10:07:11 +0000
Message-ID: <E1kcn1z-0001VU-PL@gemulon.postgresql.org> (raw)

Add pg_nodiscard decorations to some functions

Especially for the list API such as lappend() forgetting to assign the
return value is a common problem.

Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://www.postgresql.org/message-id/flat/e3753562-99cd-b65f-5aca-687dfd1ec2fc@2ndquadrant.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a378ba49a5cfec073d885f4943e1c7e4b83abd3b

Modified Files
--------------
src/include/nodes/pg_list.h | 62 ++++++++++++++++++++++-----------------------
src/include/utils/palloc.h  |  4 +--
2 files changed, 33 insertions(+), 33 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1kcn1z-0001VU-PL@gemulon.postgresql.org>
Permalink:  ../E1kcn1z-0001VU-PL@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1kcn1z-0001VU-PL@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add pg_nodiscard decorations to some functions
  In-Reply-To: <E1kcn1z-0001VU-PL@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox