pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix missing outfuncs.c support for IncrementalSortPath. 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix missing outfuncs.c support for IncrementalSortPath. @ 2020-11-30 21:33 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2020-11-30 21:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix missing outfuncs.c support for IncrementalSortPath. For debugging purposes, Path nodes are supposed to have outfuncs support, but this was overlooked in the original incremental sort patch. While at it, clean up a couple other minor oversights, as well as bizarre choice of return type for create_incremental_sort_path(). (All the existing callers just cast it to "Path *" immediately, so they don't care, but some future caller might care.) outfuncs.c fix by Zhijie Hou, the rest by me Discussion: https://postgr.es/m/324c4d81d8134117972a5b1f6cdf9560@G08CNEXMBPEKD05.g08.fujitsu.local Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a095e04f63a47ef02ec98577cc1fc4e4542e5ddd Modified Files -------------- src/backend/nodes/outfuncs.c | 23 +++++++++++++++++++++-- src/backend/optimizer/README | 1 + src/backend/optimizer/util/pathnode.c | 4 ++-- src/include/nodes/pathnodes.h | 5 ++++- src/include/optimizer/pathnode.h | 12 ++++++------ 5 files changed, 34 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix missing outfuncs.c support for IncrementalSortPath. @ 2020-11-30 21:33 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2020-11-30 21:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix missing outfuncs.c support for IncrementalSortPath. For debugging purposes, Path nodes are supposed to have outfuncs support, but this was overlooked in the original incremental sort patch. While at it, clean up a couple other minor oversights, as well as bizarre choice of return type for create_incremental_sort_path(). (All the existing callers just cast it to "Path *" immediately, so they don't care, but some future caller might care.) outfuncs.c fix by Zhijie Hou, the rest by me Discussion: https://postgr.es/m/324c4d81d8134117972a5b1f6cdf9560@G08CNEXMBPEKD05.g08.fujitsu.local Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/8286223f3d820c39f2d5f14222f7ccde53bdf502 Modified Files -------------- src/backend/nodes/outfuncs.c | 23 +++++++++++++++++++++-- src/backend/optimizer/README | 1 + src/backend/optimizer/util/pathnode.c | 4 ++-- src/include/nodes/pathnodes.h | 5 ++++- src/include/optimizer/pathnode.h | 12 ++++++------ 5 files changed, 34 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2020-11-30 21:33 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-11-30 21:33 pgsql: Fix missing outfuncs.c support for IncrementalSortPath. Tom Lane <tgl@sss.pgh.pa.us> 2020-11-30 21:33 pgsql: Fix missing outfuncs.c support for IncrementalSortPath. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox