pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix missing outfuncs.c support for IncrementalSortPath.
Date: Mon, 30 Nov 2020 21:33:54 +0000
Message-ID: <E1kjqny-0005IB-Pq@gemulon.postgresql.org> (raw)

Fix missing outfuncs.c support for IncrementalSortPath.

For debugging purposes, Path nodes are supposed to have outfuncs
support, but this was overlooked in the original incremental sort patch.

While at it, clean up a couple other minor oversights, as well as
bizarre choice of return type for create_incremental_sort_path().
(All the existing callers just cast it to "Path *" immediately, so
they don't care, but some future caller might care.)

outfuncs.c fix by Zhijie Hou, the rest by me

Discussion: https://postgr.es/m/324c4d81d8134117972a5b1f6cdf9560@G08CNEXMBPEKD05.g08.fujitsu.local

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a095e04f63a47ef02ec98577cc1fc4e4542e5ddd

Modified Files
--------------
src/backend/nodes/outfuncs.c          | 23 +++++++++++++++++++++--
src/backend/optimizer/README          |  1 +
src/backend/optimizer/util/pathnode.c |  4 ++--
src/include/nodes/pathnodes.h         |  5 ++++-
src/include/optimizer/pathnode.h      | 12 ++++++------
5 files changed, 34 insertions(+), 11 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1kjqny-0005IB-Pq@gemulon.postgresql.org>
Permalink:  ../E1kjqny-0005IB-Pq@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1kjqny-0005IB-Pq@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix missing outfuncs.c support for IncrementalSortPath.
  In-Reply-To: <E1kjqny-0005IB-Pq@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox