pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix pg_identify_object_as_address() with event triggers
Date: Wed, 28 Apr 2021 02:19:10 +0000
Message-ID: <E1lbZnC-0001tH-85@gemulon.postgresql.org> (raw)

Fix pg_identify_object_as_address() with event triggers

Attempting to use this function with event triggers failed, as, since
its introduction in a676201, this code has never associated an object
name with event triggers.  This addresses the failure by adding the
event trigger name to the set defining its object address.

Note that regression tests are added within event_trigger and not
object_address to avoid issues with concurrent connections in parallel
schedules.

Author: Joel Jacobson
Discussion: https://postgr.es/m/3c905e77-a026-46ae-8835-c3f6cd1d24c8@www.fastmail.com
Backpatch-through: 9.6

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6e41ff0562d3e1a5a88c826b0aa0b8f20bc92763

Modified Files
--------------
src/backend/catalog/objectaddress.c         | 11 +++++------
src/test/regress/expected/event_trigger.out | 15 +++++++++++++++
src/test/regress/sql/event_trigger.sql      |  9 +++++++++
3 files changed, 29 insertions(+), 6 deletions(-)



view thread (8+ messages)  latest in thread

Message-ID: <E1lbZnC-0001tH-85@gemulon.postgresql.org>
Permalink:  ../E1lbZnC-0001tH-85@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1lbZnC-0001tH-85@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix pg_identify_object_as_address() with event triggers
  In-Reply-To: <E1lbZnC-0001tH-85@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox