pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Remove XLogFileInit() ability to unlink a pre-existing file. 3+ messages / 2 participants [nested] [flat]
* pgsql: Remove XLogFileInit() ability to unlink a pre-existing file. @ 2021-06-29 01:36 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 3+ messages in thread From: Noah Misch @ 2021-06-29 01:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove XLogFileInit() ability to unlink a pre-existing file. Only initdb used it. initdb refuses to operate on a non-empty directory and generally does not cope with pre-existing files of other kinds. Hence, use the opportunity to simplify. Discussion: https://postgr.es/m/20210202151416.GB3304930@rfd.leadboat.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/421484f79c0b80209fa766eb00dbc2453a753273 Modified Files -------------- src/backend/access/transam/xlog.c | 61 ++++++++++++++--------------------- src/backend/replication/walreceiver.c | 5 ++- src/include/access/xlog.h | 2 +- 3 files changed, 28 insertions(+), 40 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Remove XLogFileInit() ability to unlink a pre-existing file. @ 2025-04-06 06:08 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2025-04-06 06:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove XLogFileInit() ability to unlink a pre-existing file. Only initdb used it. initdb refuses to operate on a non-empty directory and generally does not cope with pre-existing files of other kinds. Hence, use the opportunity to simplify. This commit has been applied as of 421484f79c0b in v15 and newer versions. This is required on stable branches of v13 and v14 to fix a regression reported by Noah Misch, introduced by 1f95181b44c8, causing spurious failures in archive recovery (neither streaming nor archive recovery) with concurrent restartpoints. The backpatched versions of the patches have been aligned on these branches by me, Noah Misch is the author. Tests have been conducted by the both of us. Reported-by: Arun Thirupathi Author: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/20210202151416.GB3304930@rfd.leadboat.com Discussion: https://postgr.es/m/20250306193013.36.nmisch@google.com Backpatch-through: 13 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b494640e8297db8b626d8ffa775cb491f7d2e7e2 Author: Noah Misch <noah@leadboat.com> Modified Files -------------- src/backend/access/transam/xlog.c | 61 ++++++++++++++--------------------- src/backend/replication/walreceiver.c | 4 +-- src/include/access/xlog.h | 2 +- 3 files changed, 28 insertions(+), 39 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Remove XLogFileInit() ability to unlink a pre-existing file. @ 2025-04-06 06:08 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2025-04-06 06:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove XLogFileInit() ability to unlink a pre-existing file. Only initdb used it. initdb refuses to operate on a non-empty directory and generally does not cope with pre-existing files of other kinds. Hence, use the opportunity to simplify. This commit has been applied as of 421484f79c0b in v15 and newer versions. This is required on stable branches of v13 and v14 to fix a regression reported by Noah Misch, introduced by 1f95181b44c8, causing spurious failures in archive recovery (neither streaming nor archive recovery) with concurrent restartpoints. The backpatched versions of the patches have been aligned on these branches by me, Noah Misch is the author. Tests have been conducted by the both of us. Reported-by: Arun Thirupathi Author: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/20210202151416.GB3304930@rfd.leadboat.com Discussion: https://postgr.es/m/20250306193013.36.nmisch@google.com Backpatch-through: 13 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d0b6acaf04a2eac17bf1533fb2991ab08da4a1be Author: Noah Misch <noah@leadboat.com> Modified Files -------------- src/backend/access/transam/xlog.c | 61 ++++++++++++++--------------------- src/backend/replication/walreceiver.c | 4 +-- src/include/access/xlog.h | 2 +- 3 files changed, 28 insertions(+), 39 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-04-06 06:08 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-06-29 01:36 pgsql: Remove XLogFileInit() ability to unlink a pre-existing file. Noah Misch <noah@leadboat.com> 2025-04-06 06:08 pgsql: Remove XLogFileInit() ability to unlink a pre-existing file. Michael Paquier <michael@paquier.xyz> 2025-04-06 06:08 pgsql: Remove XLogFileInit() ability to unlink a pre-existing file. Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox