pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove XLogFileInit() ability to unlink a pre-existing file.
Date: Tue, 29 Jun 2021 01:36:06 +0000
Message-ID: <E1ly2fW-0002av-2d@gemulon.postgresql.org> (raw)

Remove XLogFileInit() ability to unlink a pre-existing file.

Only initdb used it.  initdb refuses to operate on a non-empty directory
and generally does not cope with pre-existing files of other kinds.
Hence, use the opportunity to simplify.

Discussion: https://postgr.es/m/20210202151416.GB3304930@rfd.leadboat.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/421484f79c0b80209fa766eb00dbc2453a753273

Modified Files
--------------
src/backend/access/transam/xlog.c     | 61 ++++++++++++++---------------------
src/backend/replication/walreceiver.c |  5 ++-
src/include/access/xlog.h             |  2 +-
3 files changed, 28 insertions(+), 40 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1ly2fW-0002av-2d@gemulon.postgresql.org>
Permalink:  ../E1ly2fW-0002av-2d@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ly2fW-0002av-2d@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: noah@leadboat.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove XLogFileInit() ability to unlink a pre-existing file.
  In-Reply-To: <E1ly2fW-0002av-2d@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox