pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Deduplicate choice of horizon for a relation procarray.c.
Date: Sun, 25 Jul 2021 03:34:19 +0000
Message-ID: <E1m7UuB-0007GK-3Y@gemulon.postgresql.org> (raw)

Deduplicate choice of horizon for a relation procarray.c.

5a1e1d83022 was a minimal bug fix for dc7420c2c92. To avoid future bugs of
that kind, deduplicate the choice of a relation's horizon into a new helper,
GlobalVisHorizonKindForRel().

As the code in question was only introduced in dc7420c2c92 it seems worth
backpatching this change as well, otherwise 14 will look different from all
other branches.

A different approach to this was suggested by Matthias van de Meent.

Author: Andres Freund
Discussion: https://postgr.es/m/20210621122919.2qhu3pfugxxp3cji@alap3.anarazel.de
Backpatch: 14, like 5a1e1d83022

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d9d8aa9bb9aa2a850f53facd2c91e454129af57b

Modified Files
--------------
src/backend/storage/ipc/procarray.c | 101 +++++++++++++++++++++++-------------
1 file changed, 66 insertions(+), 35 deletions(-)



view thread (4+ messages)  latest in thread

Message-ID: <E1m7UuB-0007GK-3Y@gemulon.postgresql.org>
Permalink:  ../E1m7UuB-0007GK-3Y@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1m7UuB-0007GK-3Y@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: Deduplicate choice of horizon for a relation procarray.c.
  In-Reply-To: <E1m7UuB-0007GK-3Y@gemulon.postgresql.org>
  References: <E1m7UuB-0007GK-3Y@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox