pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't elide casting to typmod -1.
Date: Fri, 06 Aug 2021 21:33:04 +0000
Message-ID: <E1mC7Si-0002Ut-Nc@gemulon.postgresql.org> (raw)

Don't elide casting to typmod -1.

Casting a value that's already of a type with a specific typmod
to an unspecified typmod doesn't do anything so far as run-time
behavior is concerned.  However, it really ought to change the
exposed type of the expression to match.  Up to now,
coerce_type_typmod hasn't bothered with that, which creates gotchas
in contexts such as recursive unions.  If for example one side of
the union is numeric(18,3), but it needs to be plain numeric to
match the other side, there's no direct way to express that.

This is easy enough to fix, by inserting a RelabelType to update the
exposed type of the expression.  However, it's a bit nervous-making
to change this behavior, because it's stood for a really long time.
(I strongly suspect that it's like this in part because the logic
pre-dates the introduction of RelabelType in 7.0.  The commit log
message for 57b30e8e2 is interesting reading here.)  As a compromise,
we'll sneak the change into 14beta3, and consider back-patching to
stable branches if no complaints emerge in the next three months.

Discussion: https://postgr.es/m/CABNQVagu3bZGqiTjb31a8D5Od3fUMs7Oh3gmZMQZVHZ=uWWWfQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5c056b0c2519e602c2e98bace5b16d2ecde6454b

Modified Files
--------------
src/backend/parser/parse_coerce.c         | 26 ++++++++++++++--------
src/test/regress/expected/expressions.out | 37 +++++++++++++++++++++++++++++++
src/test/regress/sql/expressions.sql      | 21 ++++++++++++++++++
3 files changed, 75 insertions(+), 9 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1mC7Si-0002Ut-Nc@gemulon.postgresql.org>
Permalink:  ../E1mC7Si-0002Ut-Nc@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mC7Si-0002Ut-Nc@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Don't elide casting to typmod -1.
  In-Reply-To: <E1mC7Si-0002Ut-Nc@gemulon.postgresql.org>
  References: <E1mC7Si-0002Ut-Nc@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox