pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove --quiet option from pg_amcheck
Date: Fri, 20 Aug 2021 10:49:05 +0000
Message-ID: <E1mH25B-00033j-6G@gemulon.postgresql.org> (raw)

Remove --quiet option from pg_amcheck

Using --quiet in combination with --no-strict-names didn't work as
documented, a warning message was still emitted. Since the --quiet
flag was working in an unconventional way to other utilities, fix
by removing the functionality instead.

Backpatch through 14 where pg_amcheck was introduced.

Bug: 17148
Reported-by: Chen Jiaoqian <chenjq.jy@fujitsu.com>
Reviewed-by: Julien Rouhaud <rjuju123@gmail.com>
Discussion: https://postgr.es/m/17148-b5087318e2b04fc6@postgresql.org
Backpatch-through: 14

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/92ce7f527960ca672d2ad70e61442f4e5b3bb641

Modified Files
--------------
doc/src/sgml/ref/pg_amcheck.sgml           | 12 ----------
src/bin/pg_amcheck/pg_amcheck.c            | 38 ++++++++++--------------------
src/bin/pg_amcheck/t/002_nonesuch.pl       |  6 ++++-
src/bin/pg_amcheck/t/003_check.pl          |  2 +-
src/bin/pg_amcheck/t/005_opclass_damage.pl |  2 +-
5 files changed, 20 insertions(+), 40 deletions(-)



view thread (2+ messages)

Message-ID: <E1mH25B-00033j-6G@gemulon.postgresql.org>
Permalink:  ../E1mH25B-00033j-6G@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mH25B-00033j-6G@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org
  Subject: Re: pgsql: Remove --quiet option from pg_amcheck
  In-Reply-To: <E1mH25B-00033j-6G@gemulon.postgresql.org>
  References: <E1mH25B-00033j-6G@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox