From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix toast rewrites in logical decoding.
Date: Wed, 25 Aug 2021 04:49:58 +0000
Message-ID: <E1mIkrO-0006zX-LE@gemulon.postgresql.org> (raw)
Fix toast rewrites in logical decoding.
Commit 325f2ec555 introduced pg_class.relwrite to skip operations on
tables created as part of a heap rewrite during DDL. It links such
transient heaps to the original relation OID via this new field in
pg_class but forgot to do anything about toast tables. So, logical
decoding was not able to skip operations on internally created toast
tables. This leads to an error when we tried to decode the WAL for the
next operation for which it appeared that there is a toast data where
actually it didn't have any toast data.
To fix this, we set pg_class.relwrite for internally created toast tables
as well which allowed skipping operations on them during logical decoding.
Author: Bertrand Drouvot
Reviewed-by: David Zhang, Amit Kapila
Backpatch-through: 11, where it was introduced
Discussion: https://postgr.es/m/b5146fb1-ad9e-7d6e-f980-98ed68744a7c@amazon.com
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e35705f549f0bb8f0318cd8a08244ba40ba9bdd2
Modified Files
--------------
contrib/test_decoding/expected/toast.out | 22 ++++++++++++++++++++++
contrib/test_decoding/sql/toast.sql | 16 ++++++++++++++++
src/backend/catalog/toasting.c | 29 ++++++++++++++++++-----------
src/backend/commands/cluster.c | 10 +++++++++-
src/backend/commands/tablecmds.c | 31 +++++++++++++++++++++++++++++++
src/include/catalog/toasting.h | 2 +-
src/include/commands/tablecmds.h | 2 ++
7 files changed, 99 insertions(+), 13 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: akapila@postgresql.org
Subject: Re: pgsql: Fix toast rewrites in logical decoding.
In-Reply-To: <E1mIkrO-0006zX-LE@gemulon.postgresql.org>
References: <E1mIkrO-0006zX-LE@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox