pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: John Naylor <john.naylor@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert "Change mbbisearch to return the character range"
Date: Thu, 26 Aug 2021 14:07:43 +0000
Message-ID: <E1mJG2h-0002BC-TK@gemulon.postgresql.org> (raw)

Revert "Change mbbisearch to return the character range"

This reverts commit 78ab944cd4b9977732becd9d0bc83223b88af9a2.

After I had committed eb0d0d2c7 and 78ab944cd, I decided to add
a sanity check for a "can't happen" scenario just to be cautious.
It turned out that it already happened in the official Unicode source
data, namely that a character can be both wide and a combining
character. This fact renders the aforementioned commits unnecessary,
so revert both of them.

Discussion:
https://www.postgresql.org/message-id/CAFBsxsH5ejH4-1xaTLpSK8vWoK1m6fA1JBtTM6jmBsLfmDki1g%40mail.gma...

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f8c8a8bccc23f6ca38f7a92c9a614e73fa1fcfb6

Modified Files
--------------
src/common/unicode/generate-unicode_width_table.pl |   4 +-
src/common/wchar.c                                 |  21 +-
src/include/common/unicode_width_table.h           | 386 ++++++++++-----------
3 files changed, 203 insertions(+), 208 deletions(-)



Message-ID: <E1mJG2h-0002BC-TK@gemulon.postgresql.org>
Permalink:  ../E1mJG2h-0002BC-TK@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mJG2h-0002BC-TK@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: john.naylor@postgresql.org
  Subject: Re: pgsql: Revert "Change mbbisearch to return the character range"
  In-Reply-To: <E1mJG2h-0002BC-TK@gemulon.postgresql.org>
  References: <E1mJG2h-0002BC-TK@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox