From: John Naylor <john.naylor@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert "Rename unicode_combining_table to unicode_width_table"
Date: Thu, 26 Aug 2021 14:07:43 +0000
Message-ID: <E1mJG2h-0002BD-Tn@gemulon.postgresql.org> (raw)
Revert "Rename unicode_combining_table to unicode_width_table"
This reverts commit eb0d0d2c7300c9c5c22b35975c11265aa4becc84.
After I had committed eb0d0d2c7 and 78ab944cd, I decided to add
a sanity check for a "can't happen" scenario just to be cautious.
It turned out that it already happened in the official Unicode source
data, namely that a character can be both wide and a combining
character. This fact renders the aforementioned commits unnecessary,
so revert both of them.
Discussion: https://www.postgresql.org/message-id/CAFBsxsH5ejH4-1xaTLpSK8vWoK1m6fA1JBtTM6jmBsLfmDki1g%40mail.gma...
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/1563ecbc1be8b8e5c57651cf5c87f90dea9aea8f
Modified Files
--------------
src/common/unicode/Makefile | 4 ++--
...ate-unicode_width_table.pl => generate-unicode_combining_table.pl} | 2 +-
src/common/wchar.c | 2 +-
.../common/{unicode_width_table.h => unicode_combining_table.h} | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: john.naylor@postgresql.org
Subject: Re: pgsql: Revert "Rename unicode_combining_table to unicode_width_table"
In-Reply-To: <E1mJG2h-0002BD-Tn@gemulon.postgresql.org>
References: <E1mJG2h-0002BD-Tn@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox