pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: John Naylor <john.naylor@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Update display widths as part of updating Unicode
Date: Thu, 26 Aug 2021 15:06:00 +0000
Message-ID: <E1mJGx6-0002Xn-4v@gemulon.postgresql.org> (raw)

Update display widths as part of updating Unicode

The hardcoded "wide character" set in ucs_wcwidth() was last updated
around the Unicode 5.0 era.  This led to misalignment when printing
emojis and other codepoints that have since been designated
wide or full-width.

To fix and keep up to date, extend update-unicode to download the list
of wide and full-width codepoints from the offical sources.

In passing, remove some comments about non-spacing characters that
haven't been accurate since we removed the former hardcoded logic.

Jacob Champion

Reported and reviewed by Pavel Stehule
Discussion: https://www.postgresql.org/message-id/flat/CAFj8pRCeX21O69YHxmykYySYyprZAqrKWWg0KoGKdjgqcGyygg@mail....

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bab982161e0590746a2fd2a03043b27108b23ac6

Modified Files
--------------
src/common/unicode/.gitignore                      |   1 +
src/common/unicode/Makefile                        |   9 +-
.../generate-unicode_east_asian_fw_table.pl        |  76 +++++++++++++
src/common/wchar.c                                 |  41 +++----
src/include/common/unicode_east_asian_fw_table.h   | 120 +++++++++++++++++++++
5 files changed, 220 insertions(+), 27 deletions(-)



Message-ID: <E1mJGx6-0002Xn-4v@gemulon.postgresql.org>
Permalink:  ../E1mJGx6-0002Xn-4v@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mJGx6-0002Xn-4v@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: john.naylor@postgresql.org
  Subject: Re: pgsql: Update display widths as part of updating Unicode
  In-Reply-To: <E1mJGx6-0002Xn-4v@gemulon.postgresql.org>
  References: <E1mJGx6-0002Xn-4v@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox