pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Refactor sharedfileset.c to separate out fileset implementation.
Date: Mon, 30 Aug 2021 03:39:34 +0000
Message-ID: <E1mKY90-0003ZU-MP@gemulon.postgresql.org> (raw)

Refactor sharedfileset.c to separate out fileset implementation.

Move fileset related implementation out of sharedfileset.c to allow its
usage by backends that don't want to share filesets among different
processes. After this split, fileset infrastructure is used by both
sharedfileset.c and worker.c for the named temporary files that survive
across transactions.

Author: Dilip Kumar, based on suggestion by Andres Freund
Reviewed-by: Hou Zhijie, Masahiko Sawada, Amit Kapila
Discussion: https://postgr.es/m/E1mCC6U-0004Ik-Fs@gemulon.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/dcac5e7ac157964f71f15d81c7429130c69c3f9b

Modified Files
--------------
src/backend/replication/logical/launcher.c |   3 +
src/backend/replication/logical/worker.c   |  82 ++++++----
src/backend/storage/file/Makefile          |   1 +
src/backend/storage/file/buffile.c         |  84 +++++-----
src/backend/storage/file/fd.c              |   2 +-
src/backend/storage/file/fileset.c         | 205 ++++++++++++++++++++++++
src/backend/storage/file/sharedfileset.c   | 244 +----------------------------
src/backend/utils/sort/logtape.c           |   8 +-
src/backend/utils/sort/sharedtuplestore.c  |   5 +-
src/include/replication/worker_internal.h  |   1 +
src/include/storage/buffile.h              |  14 +-
src/include/storage/fileset.h              |  40 +++++
src/include/storage/sharedfileset.h        |  14 +-
src/tools/pgindent/typedefs.list           |   1 +
14 files changed, 368 insertions(+), 336 deletions(-)



Message-ID: <E1mKY90-0003ZU-MP@gemulon.postgresql.org>
Permalink:  ../E1mKY90-0003ZU-MP@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mKY90-0003ZU-MP@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org
  Subject: Re: pgsql: Refactor sharedfileset.c to separate out fileset implementation.
  In-Reply-To: <E1mKY90-0003ZU-MP@gemulon.postgresql.org>
  References: <E1mKY90-0003ZU-MP@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox