pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pgbench: Avoid unnecessary measurement of connection delays.
Date: Mon, 30 Aug 2021 12:41:43 +0000
Message-ID: <E1mKgbf-0008UO-Vu@gemulon.postgresql.org> (raw)

pgbench: Avoid unnecessary measurement of connection delays.

Commit 547f04e734 changed pgbench so that it used the measurement result
of connection delays in its benchmark report only when -C/--connect option
is specified. But previously those delays were unnecessarily measured
even when that option is not specified. Which was a waste of cycles.
This commit improves pgbench so that it avoids such unnecessary measurement.

Back-patch to v14 where commit 547f04e734 first appeared.

Author: Yugo Nagata
Reviewed-by: Fabien COELHO, Asif Rehman, Fujii Masao
Discussion: https://postgr.es/m/20210614151155.a393bc7d8fed183e38c9f52a@sraoss.co.jp

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/efe2382d5ade2c8d63f2aa1b48cc85691a2bfabd

Modified Files
--------------
src/bin/pgbench/pgbench.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)



view thread (2+ messages)

Message-ID: <E1mKgbf-0008UO-Vu@gemulon.postgresql.org>
Permalink:  ../E1mKgbf-0008UO-Vu@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mKgbf-0008UO-Vu@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: fujii@postgresql.org
  Subject: Re: pgsql: pgbench: Avoid unnecessary measurement of connection delays.
  In-Reply-To: <E1mKgbf-0008UO-Vu@gemulon.postgresql.org>
  References: <E1mKgbf-0008UO-Vu@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox