pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Cache the results of format_type() queries in pg_dump.
Date: Tue, 31 Aug 2021 17:54:12 +0000
Message-ID: <E1mL7xc-0004AV-GM@gemulon.postgresql.org> (raw)

Cache the results of format_type() queries in pg_dump.

There's long been a "TODO: there might be some value in caching
the results" annotation on pg_dump's getFormattedTypeName function;
but we hadn't gotten around to checking what it was costing us to
repetitively look up type names.  It turns out that when dumping the
current regression database, about 10% of the total number of queries
issued are duplicative format_type() queries.  However, Hubert Depesz
Lubaczewski reported a not-unusual case where these account for over
half of the queries issued by pg_dump.  Individually these queries
aren't expensive, but when network lag is a factor, they add up to a
problem.  We can very easily add some caching to getFormattedTypeName
to solve it.

Since this is such a simple fix and can have a visible performance
benefit, back-patch to all supported branches.

Discussion: https://postgr.es/m/20210826084430.GA26282@depesz.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2f1ed9d98c38a62ffa4b0a6589c9fcc529ae0883

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 13 +++++++++++--
src/bin/pg_dump/pg_dump.h |  6 ++++--
2 files changed, 15 insertions(+), 4 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1mL7xc-0004AV-GM@gemulon.postgresql.org>
Permalink:  ../E1mL7xc-0004AV-GM@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mL7xc-0004AV-GM@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Cache the results of format_type() queries in pg_dump.
  In-Reply-To: <E1mL7xc-0004AV-GM@gemulon.postgresql.org>
  References: <E1mL7xc-0004AV-GM@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox