pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix the random test failure in 001_rep_changes.
6+ messages / 1 participants
[nested] [flat]

* pgsql: Fix the random test failure in 001_rep_changes.
@ 2021-09-01 04:59 Amit Kapila <akapila@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Amit Kapila @ 2021-09-01 04:59 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix the random test failure in 001_rep_changes.

The check to test whether the subscription workers were restarting after a
change in the subscription was failing. The reason was that the test was
assuming the walsender started before it reaches the 'streaming' state and
the walsender was exiting due to an error before that. Now, the walsender
was erroring out before reaching the 'streaming' state because it tries to
acquire the slot before the previous walsender has exited.

In passing, improve the die messages so that it is easier to investigate
the failures in the future if any.

Reported-by: Michael Paquier, as per buildfarm
Author: Ajin Cherian
Reviewed-by: Masahiko Sawada, Amit Kapila
Backpatch-through: 10, where this test was introduced
Discussion: https://postgr.es/m/YRnhFxa9bo73wfpV@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8d0138ef51b51ba3e419cf49069eb72a15f74706

Modified Files
--------------
src/test/subscription/t/001_rep_changes.pl      | 26 +++++++++++++------------
src/test/subscription/t/022_twophase_cascade.pl |  8 ++++----
2 files changed, 18 insertions(+), 16 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Fix the random test failure in 001_rep_changes.
@ 2021-09-01 04:59 Amit Kapila <akapila@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Amit Kapila @ 2021-09-01 04:59 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix the random test failure in 001_rep_changes.

The check to test whether the subscription workers were restarting after a
change in the subscription was failing. The reason was that the test was
assuming the walsender started before it reaches the 'streaming' state and
the walsender was exiting due to an error before that. Now, the walsender
was erroring out before reaching the 'streaming' state because it tries to
acquire the slot before the previous walsender has exited.

In passing, improve the die messages so that it is easier to investigate
the failures in the future if any.

Reported-by: Michael Paquier, as per buildfarm
Author: Ajin Cherian
Reviewed-by: Masahiko Sawada, Amit Kapila
Backpatch-through: 10, where this test was introduced
Discussion: https://postgr.es/m/YRnhFxa9bo73wfpV@paquier.xyz

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b7ad093d50e13aadfffb1662f53cd16a1c59e09d

Modified Files
--------------
src/test/subscription/t/001_rep_changes.pl | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Fix the random test failure in 001_rep_changes.
@ 2021-09-01 04:59 Amit Kapila <akapila@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Amit Kapila @ 2021-09-01 04:59 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix the random test failure in 001_rep_changes.

The check to test whether the subscription workers were restarting after a
change in the subscription was failing. The reason was that the test was
assuming the walsender started before it reaches the 'streaming' state and
the walsender was exiting due to an error before that. Now, the walsender
was erroring out before reaching the 'streaming' state because it tries to
acquire the slot before the previous walsender has exited.

In passing, improve the die messages so that it is easier to investigate
the failures in the future if any.

Reported-by: Michael Paquier, as per buildfarm
Author: Ajin Cherian
Reviewed-by: Masahiko Sawada, Amit Kapila
Backpatch-through: 10, where this test was introduced
Discussion: https://postgr.es/m/YRnhFxa9bo73wfpV@paquier.xyz

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b51985d8a0e1a7487d17559cbeefc87892c4d916

Modified Files
--------------
src/test/subscription/t/001_rep_changes.pl | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Fix the random test failure in 001_rep_changes.
@ 2021-09-01 04:59 Amit Kapila <akapila@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Amit Kapila @ 2021-09-01 04:59 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix the random test failure in 001_rep_changes.

The check to test whether the subscription workers were restarting after a
change in the subscription was failing. The reason was that the test was
assuming the walsender started before it reaches the 'streaming' state and
the walsender was exiting due to an error before that. Now, the walsender
was erroring out before reaching the 'streaming' state because it tries to
acquire the slot before the previous walsender has exited.

In passing, improve the die messages so that it is easier to investigate
the failures in the future if any.

Reported-by: Michael Paquier, as per buildfarm
Author: Ajin Cherian
Reviewed-by: Masahiko Sawada, Amit Kapila
Backpatch-through: 10, where this test was introduced
Discussion: https://postgr.es/m/YRnhFxa9bo73wfpV@paquier.xyz

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/df6ab94aca9015eebd0fc74da8b9d5cc179a0ced

Modified Files
--------------
src/test/subscription/t/001_rep_changes.pl | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Fix the random test failure in 001_rep_changes.
@ 2021-09-01 04:59 Amit Kapila <akapila@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Amit Kapila @ 2021-09-01 04:59 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix the random test failure in 001_rep_changes.

The check to test whether the subscription workers were restarting after a
change in the subscription was failing. The reason was that the test was
assuming the walsender started before it reaches the 'streaming' state and
the walsender was exiting due to an error before that. Now, the walsender
was erroring out before reaching the 'streaming' state because it tries to
acquire the slot before the previous walsender has exited.

In passing, improve the die messages so that it is easier to investigate
the failures in the future if any.

Reported-by: Michael Paquier, as per buildfarm
Author: Ajin Cherian
Reviewed-by: Masahiko Sawada, Amit Kapila
Backpatch-through: 10, where this test was introduced
Discussion: https://postgr.es/m/YRnhFxa9bo73wfpV@paquier.xyz

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/56683e1684efc07faefb6dc932305d8077588791

Modified Files
--------------
src/test/subscription/t/001_rep_changes.pl | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Fix the random test failure in 001_rep_changes.
@ 2021-09-01 04:59 Amit Kapila <akapila@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Amit Kapila @ 2021-09-01 04:59 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix the random test failure in 001_rep_changes.

The check to test whether the subscription workers were restarting after a
change in the subscription was failing. The reason was that the test was
assuming the walsender started before it reaches the 'streaming' state and
the walsender was exiting due to an error before that. Now, the walsender
was erroring out before reaching the 'streaming' state because it tries to
acquire the slot before the previous walsender has exited.

In passing, improve the die messages so that it is easier to investigate
the failures in the future if any.

Reported-by: Michael Paquier, as per buildfarm
Author: Ajin Cherian
Reviewed-by: Masahiko Sawada, Amit Kapila
Backpatch-through: 10, where this test was introduced
Discussion: https://postgr.es/m/YRnhFxa9bo73wfpV@paquier.xyz

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/387093e432253784f49cb0c129c882bb310b9d9b

Modified Files
--------------
src/test/subscription/t/001_rep_changes.pl | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2021-09-01 04:59 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 04:59 pgsql: Fix the random test failure in 001_rep_changes. Amit Kapila <akapila@postgresql.org>
2021-09-01 04:59 pgsql: Fix the random test failure in 001_rep_changes. Amit Kapila <akapila@postgresql.org>
2021-09-01 04:59 pgsql: Fix the random test failure in 001_rep_changes. Amit Kapila <akapila@postgresql.org>
2021-09-01 04:59 pgsql: Fix the random test failure in 001_rep_changes. Amit Kapila <akapila@postgresql.org>
2021-09-01 04:59 pgsql: Fix the random test failure in 001_rep_changes. Amit Kapila <akapila@postgresql.org>
2021-09-01 04:59 pgsql: Fix the random test failure in 001_rep_changes. Amit Kapila <akapila@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox