pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix the random test failure in 001_rep_changes.
Date: Wed, 01 Sep 2021 04:59:33 +0000
Message-ID: <E1mLILV-0000GE-1b@gemulon.postgresql.org> (raw)

Fix the random test failure in 001_rep_changes.

The check to test whether the subscription workers were restarting after a
change in the subscription was failing. The reason was that the test was
assuming the walsender started before it reaches the 'streaming' state and
the walsender was exiting due to an error before that. Now, the walsender
was erroring out before reaching the 'streaming' state because it tries to
acquire the slot before the previous walsender has exited.

In passing, improve the die messages so that it is easier to investigate
the failures in the future if any.

Reported-by: Michael Paquier, as per buildfarm
Author: Ajin Cherian
Reviewed-by: Masahiko Sawada, Amit Kapila
Backpatch-through: 10, where this test was introduced
Discussion: https://postgr.es/m/YRnhFxa9bo73wfpV@paquier.xyz

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/56683e1684efc07faefb6dc932305d8077588791

Modified Files
--------------
src/test/subscription/t/001_rep_changes.pl | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1mLILV-0000GE-1b@gemulon.postgresql.org>
Permalink:  ../E1mLILV-0000GE-1b@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mLILV-0000GE-1b@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org
  Subject: Re: pgsql: Fix the random test failure in 001_rep_changes.
  In-Reply-To: <E1mLILV-0000GE-1b@gemulon.postgresql.org>
  References: <E1mLILV-0000GE-1b@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox