pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pgbench: Fix bug in measurement of disconnection delays.
Date: Wed, 01 Sep 2021 08:06:33 +0000
Message-ID: <E1mLLGT-0001R6-LF@gemulon.postgresql.org> (raw)

pgbench: Fix bug in measurement of disconnection delays.

When -C/--connect option is specified, pgbench establishes and closes
the connection for each transaction. In this case pgbench needs to
measure the times taken for all those connections and disconnections,
to include the average connection time in the benchmark result.
But previously pgbench could not measure those disconnection delays.
To fix the bug, this commit makes pgbench measure the disconnection
delays whenever the connection is closed at the end of transaction,
if -C/--connect option is specified.

Back-patch to v14. Per discussion, we concluded not to back-patch to v13
or before because changing that behavior in stable branches would
surprise users rather than providing benefits.

Author: Yugo Nagata
Reviewed-by: Fabien COELHO, Tatsuo Ishii, Asif Rehman, Fujii Masao
Discussion: https://postgr.es/m/20210614151155.a393bc7d8fed183e38c9f52a@sraoss.co.jp

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d760d942c73c9a161feefb7dc4a0004b9b4e7787

Modified Files
--------------
src/bin/pgbench/pgbench.c | 27 +++++++++++++++++++++++----
1 file changed, 23 insertions(+), 4 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1mLLGT-0001R6-LF@gemulon.postgresql.org>
Permalink:  ../E1mLLGT-0001R6-LF@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mLLGT-0001R6-LF@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: fujii@postgresql.org
  Subject: Re: pgsql: pgbench: Fix bug in measurement of disconnection delays.
  In-Reply-To: <E1mLLGT-0001R6-LF@gemulon.postgresql.org>
  References: <E1mLLGT-0001R6-LF@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox