pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Refactor postgresImportForeignSchema to avoid code duplication.
Date: Wed, 01 Sep 2021 20:21:20 +0000
Message-ID: <E1mLWjY-0006H6-GN@gemulon.postgresql.org> (raw)

Refactor postgresImportForeignSchema to avoid code duplication.

Avoid repeating fragments of the query we're building, along the
same lines as recent cleanup in pg_dump.  I got annoyed about this
because aa769f80e broke my pending patch to change postgres_fdw's
collation handling, due to each of us having incompletely done
this same refactoring.  Let's finish that job in hopes of having
a more stable base.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2dc53fe2a77d8d5f22c656fdf6590198e358a996

Modified Files
--------------
contrib/postgres_fdw/postgres_fdw.c | 50 +++++++++++++++++--------------------
1 file changed, 23 insertions(+), 27 deletions(-)



Message-ID: <E1mLWjY-0006H6-GN@gemulon.postgresql.org>
Permalink:  ../E1mLWjY-0006H6-GN@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mLWjY-0006H6-GN@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Refactor postgresImportForeignSchema to avoid code duplication.
  In-Reply-To: <E1mLWjY-0006H6-GN@gemulon.postgresql.org>
  References: <E1mLWjY-0006H6-GN@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox