pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: In count_usable_fds(), duplicate stderr not stdin.
Date: Thu, 02 Sep 2021 22:53:19 +0000
Message-ID: <E1mLvaB-0000To-QB@gemulon.postgresql.org> (raw)

In count_usable_fds(), duplicate stderr not stdin.

We had a complaint that the postmaster fails to start if the invoking
program closes stdin.  That happens because count_usable_fds expects
to be able to dup(0), and if it can't, we conclude there are no free
FDs and go belly-up.  So far as I can find, though, there is no other
place in the server that touches stdin, and it's not unreasonable to
expect that a daemon wouldn't use that file.

As a simple improvement, let's dup FD 2 (stderr) instead.  Unlike stdin,
it *is* reasonable for us to expect that stderr be open; even if we are
configured not to touch it, common libraries such as libc might try to
write error messages there.

Per gripe from Mario Emmenlauer.  Given the lack of previous complaints,
I'm not excited about pushing this into stable branches, but it seems
OK to squeeze it into v14.

Discussion: https://postgr.es/m/48bafc63-c30f-3962-2ded-f2e985d93e86@emmenlauer.de

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6b54f12332a184bfd03524c012795678ddc992f4

Modified Files
--------------
src/backend/storage/file/fd.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)



view thread (2+ messages)

Message-ID: <E1mLvaB-0000To-QB@gemulon.postgresql.org>
Permalink:  ../E1mLvaB-0000To-QB@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mLvaB-0000To-QB@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: In count_usable_fds(), duplicate stderr not stdin.
  In-Reply-To: <E1mLvaB-0000To-QB@gemulon.postgresql.org>
  References: <E1mLvaB-0000To-QB@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox