pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl.
Date: Sat, 04 Sep 2021 01:05:09 +0000
Message-ID: <E1mMK7J-0002yo-20@gemulon.postgresql.org> (raw)

Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl.

Replace fixed-length command buffers with psprintf() calls.  We didn't
have anything as convenient as psprintf() when this code was written,
but now that we do, there's little reason for the limitation to
stand.  Removing it eliminates some corner cases where (for example)
starting the postmaster with a whole lot of options fails.

Most individual file names that pg_ctl deals with are still restricted
to MAXPGPATH, but we've seldom had complaints about that limitation
so long as it only applies to one filename.

Back-patch to all supported branches.

Phil Krylov

Discussion: https://postgr.es/m/567e199c6b97ee19deee600311515b86@krylov.eu

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/87ad491472d6f8620d83ec9db4f515ce303052ac

Modified Files
--------------
src/bin/pg_ctl/pg_ctl.c | 44 ++++++++++++++++++++++----------------------
1 file changed, 22 insertions(+), 22 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1mMK7J-0002yo-20@gemulon.postgresql.org>
Permalink:  ../E1mMK7J-0002yo-20@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mMK7J-0002yo-20@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl.
  In-Reply-To: <E1mMK7J-0002yo-20@gemulon.postgresql.org>
  References: <E1mMK7J-0002yo-20@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox