pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. 7+ messages / 1 participants [nested] [flat]
* pgsql: Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. @ 2021-09-04 01:05 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2021-09-04 01:05 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. Replace fixed-length command buffers with psprintf() calls. We didn't have anything as convenient as psprintf() when this code was written, but now that we do, there's little reason for the limitation to stand. Removing it eliminates some corner cases where (for example) starting the postmaster with a whole lot of options fails. Most individual file names that pg_ctl deals with are still restricted to MAXPGPATH, but we've seldom had complaints about that limitation so long as it only applies to one filename. Back-patch to all supported branches. Phil Krylov Discussion: https://postgr.es/m/567e199c6b97ee19deee600311515b86@krylov.eu Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/87ad491472d6f8620d83ec9db4f515ce303052ac Modified Files -------------- src/bin/pg_ctl/pg_ctl.c | 44 ++++++++++++++++++++++---------------------- 1 file changed, 22 insertions(+), 22 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. @ 2021-09-04 01:05 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2021-09-04 01:05 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. Replace fixed-length command buffers with psprintf() calls. We didn't have anything as convenient as psprintf() when this code was written, but now that we do, there's little reason for the limitation to stand. Removing it eliminates some corner cases where (for example) starting the postmaster with a whole lot of options fails. Most individual file names that pg_ctl deals with are still restricted to MAXPGPATH, but we've seldom had complaints about that limitation so long as it only applies to one filename. Back-patch to all supported branches. Phil Krylov Discussion: https://postgr.es/m/567e199c6b97ee19deee600311515b86@krylov.eu Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/69d670e68ec9bd00b71ddc528274746790d7b6bd Modified Files -------------- src/bin/pg_ctl/pg_ctl.c | 44 ++++++++++++++++++++++---------------------- 1 file changed, 22 insertions(+), 22 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. @ 2021-09-04 01:05 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2021-09-04 01:05 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. Replace fixed-length command buffers with psprintf() calls. We didn't have anything as convenient as psprintf() when this code was written, but now that we do, there's little reason for the limitation to stand. Removing it eliminates some corner cases where (for example) starting the postmaster with a whole lot of options fails. Most individual file names that pg_ctl deals with are still restricted to MAXPGPATH, but we've seldom had complaints about that limitation so long as it only applies to one filename. Back-patch to all supported branches. Phil Krylov Discussion: https://postgr.es/m/567e199c6b97ee19deee600311515b86@krylov.eu Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/742b30caee65a8d54388c1a249e93f27c65315f5 Modified Files -------------- src/bin/pg_ctl/pg_ctl.c | 44 ++++++++++++++++++++++---------------------- 1 file changed, 22 insertions(+), 22 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. @ 2021-09-04 01:05 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2021-09-04 01:05 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. Replace fixed-length command buffers with psprintf() calls. We didn't have anything as convenient as psprintf() when this code was written, but now that we do, there's little reason for the limitation to stand. Removing it eliminates some corner cases where (for example) starting the postmaster with a whole lot of options fails. Most individual file names that pg_ctl deals with are still restricted to MAXPGPATH, but we've seldom had complaints about that limitation so long as it only applies to one filename. Back-patch to all supported branches. Phil Krylov Discussion: https://postgr.es/m/567e199c6b97ee19deee600311515b86@krylov.eu Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3b302eb1ea2e9cb610ccc3a4f819dddfc89418ca Modified Files -------------- src/bin/pg_ctl/pg_ctl.c | 44 ++++++++++++++++++++++---------------------- 1 file changed, 22 insertions(+), 22 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. @ 2021-09-04 01:05 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2021-09-04 01:05 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. Replace fixed-length command buffers with psprintf() calls. We didn't have anything as convenient as psprintf() when this code was written, but now that we do, there's little reason for the limitation to stand. Removing it eliminates some corner cases where (for example) starting the postmaster with a whole lot of options fails. Most individual file names that pg_ctl deals with are still restricted to MAXPGPATH, but we've seldom had complaints about that limitation so long as it only applies to one filename. Back-patch to all supported branches. Phil Krylov Discussion: https://postgr.es/m/567e199c6b97ee19deee600311515b86@krylov.eu Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/beb404d3b165ab1cc0dae56b71a6929b4742a10b Modified Files -------------- src/bin/pg_ctl/pg_ctl.c | 44 ++++++++++++++++++++++---------------------- 1 file changed, 22 insertions(+), 22 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. @ 2021-09-04 01:05 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2021-09-04 01:05 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. Replace fixed-length command buffers with psprintf() calls. We didn't have anything as convenient as psprintf() when this code was written, but now that we do, there's little reason for the limitation to stand. Removing it eliminates some corner cases where (for example) starting the postmaster with a whole lot of options fails. Most individual file names that pg_ctl deals with are still restricted to MAXPGPATH, but we've seldom had complaints about that limitation so long as it only applies to one filename. Back-patch to all supported branches. Phil Krylov Discussion: https://postgr.es/m/567e199c6b97ee19deee600311515b86@krylov.eu Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6e2f4581781b5bc509012ac9e0718deb707635b2 Modified Files -------------- src/bin/pg_ctl/pg_ctl.c | 44 ++++++++++++++++++++++---------------------- 1 file changed, 22 insertions(+), 22 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. @ 2021-09-04 01:05 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2021-09-04 01:05 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. Replace fixed-length command buffers with psprintf() calls. We didn't have anything as convenient as psprintf() when this code was written, but now that we do, there's little reason for the limitation to stand. Removing it eliminates some corner cases where (for example) starting the postmaster with a whole lot of options fails. Most individual file names that pg_ctl deals with are still restricted to MAXPGPATH, but we've seldom had complaints about that limitation so long as it only applies to one filename. Back-patch to all supported branches. Phil Krylov Discussion: https://postgr.es/m/567e199c6b97ee19deee600311515b86@krylov.eu Branch ------ REL9_6_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9a070c6589069d94e04cfccc4dc9279478f123ae Modified Files -------------- src/bin/pg_ctl/pg_ctl.c | 44 ++++++++++++++++++++++---------------------- 1 file changed, 22 insertions(+), 22 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2021-09-04 01:05 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-09-04 01:05 pgsql: Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. Tom Lane <tgl@sss.pgh.pa.us> 2021-09-04 01:05 pgsql: Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. Tom Lane <tgl@sss.pgh.pa.us> 2021-09-04 01:05 pgsql: Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. Tom Lane <tgl@sss.pgh.pa.us> 2021-09-04 01:05 pgsql: Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. Tom Lane <tgl@sss.pgh.pa.us> 2021-09-04 01:05 pgsql: Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. Tom Lane <tgl@sss.pgh.pa.us> 2021-09-04 01:05 pgsql: Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. Tom Lane <tgl@sss.pgh.pa.us> 2021-09-04 01:05 pgsql: Remove arbitrary MAXPGPATH limit on command lengths in pg_ctl. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox