pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: AIX: Fix missing libpq symbols by respecting SHLIB_EXPORTS.
Date: Mon, 06 Sep 2021 18:32:49 +0000
Message-ID: <E1mNJQH-0004gr-Ps@gemulon.postgresql.org> (raw)

AIX: Fix missing libpq symbols by respecting SHLIB_EXPORTS.

We make each AIX shared library export all globals found in .o files
that originate in the library.  That doesn't include symbols acquired by
-lpgcommon_shlib.  That is good on average, but it became a problem for
libpq when commit e6afa8918c461c1dd80c5063a950518fa4e950cd moved five
official libpq API symbols into src/common.  Fix this by implementing
the SHLIB_EXPORTS mechanism for AIX, so affected libraries export the
same symbols that they export on Linux.  This reintroduces symbols
pg_encoding_to_char, pg_utf_mblen, pg_char_to_encoding,
pg_valid_server_encoding, and pg_valid_server_encoding_id.  Back-patch
to v13, where the aforementioned commit first appeared.  While a minor
release is usually the wrong time to add or remove symbol exports in
libpq or libecpg, we should expect users to want each documented symbol.

Tony Reix

Discussion: https://postgr.es/m/PR3PR02MB6396742E2FC3E77D37A920BC86C79@PR3PR02MB6396.eurprd02.prod.outlook.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/aae398a87cfafcb1d62fd1e464b2c4d2525a039a

Modified Files
--------------
src/Makefile.shlib | 4 ++++
src/port/README    | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)



view thread (3+ messages)

Message-ID: <E1mNJQH-0004gr-Ps@gemulon.postgresql.org>
Permalink:  ../E1mNJQH-0004gr-Ps@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mNJQH-0004gr-Ps@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: noah@leadboat.com
  Subject: Re: pgsql: AIX: Fix missing libpq symbols by respecting SHLIB_EXPORTS.
  In-Reply-To: <E1mNJQH-0004gr-Ps@gemulon.postgresql.org>
  References: <E1mNJQH-0004gr-Ps@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox