pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Invalidate relcache for publications defined for all tables. 6+ messages / 1 participants [nested] [flat]
* pgsql: Invalidate relcache for publications defined for all tables. @ 2021-09-08 06:50 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Amit Kapila @ 2021-09-08 06:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Invalidate relcache for publications defined for all tables. Updates/Deletes on a relation were allowed even without replica identity after we define the publication for all tables. This would later lead to an error on subscribers. The reason was that for such publications we were not invalidating the relcache and the publication information for relations was not getting rebuilt. Similarly, we were not invalidating the relcache after dropping of such publications which will prohibit Updates/Deletes without replica identity even without any publication. Author: Vignesh C and Hou Zhijie Reviewed-by: Hou Zhijie, Kyotaro Horiguchi, Amit Kapila Backpatch-through: 10, where it was introduced Discussion: https://postgr.es/m/CALDaNm0pF6zeWqCA8TCe2sDuwFAy8fCqba=nHampCKag-qLixg@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/8bd534274099aabf721ca4baef2e8a3a379d7b02 Modified Files -------------- src/backend/catalog/dependency.c | 5 ++++- src/backend/commands/publicationcmds.c | 34 +++++++++++++++++++++++++++++++ src/include/commands/publicationcmds.h | 1 + src/test/regress/expected/publication.out | 15 ++++++++++++++ src/test/regress/sql/publication.sql | 14 +++++++++++++ 5 files changed, 68 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Invalidate relcache for publications defined for all tables. @ 2021-09-08 06:50 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Amit Kapila @ 2021-09-08 06:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Invalidate relcache for publications defined for all tables. Updates/Deletes on a relation were allowed even without replica identity after we define the publication for all tables. This would later lead to an error on subscribers. The reason was that for such publications we were not invalidating the relcache and the publication information for relations was not getting rebuilt. Similarly, we were not invalidating the relcache after dropping of such publications which will prohibit Updates/Deletes without replica identity even without any publication. Author: Vignesh C and Hou Zhijie Reviewed-by: Hou Zhijie, Kyotaro Horiguchi, Amit Kapila Backpatch-through: 10, where it was introduced Discussion: https://postgr.es/m/CALDaNm0pF6zeWqCA8TCe2sDuwFAy8fCqba=nHampCKag-qLixg@mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8db27fbc11974ef491fec97be3365277ed4fab20 Modified Files -------------- src/backend/catalog/dependency.c | 5 ++++- src/backend/commands/publicationcmds.c | 34 +++++++++++++++++++++++++++++++ src/include/commands/publicationcmds.h | 1 + src/test/regress/expected/publication.out | 15 ++++++++++++++ src/test/regress/sql/publication.sql | 14 +++++++++++++ 5 files changed, 68 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Invalidate relcache for publications defined for all tables. @ 2021-09-08 06:50 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Amit Kapila @ 2021-09-08 06:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Invalidate relcache for publications defined for all tables. Updates/Deletes on a relation were allowed even without replica identity after we define the publication for all tables. This would later lead to an error on subscribers. The reason was that for such publications we were not invalidating the relcache and the publication information for relations was not getting rebuilt. Similarly, we were not invalidating the relcache after dropping of such publications which will prohibit Updates/Deletes without replica identity even without any publication. Author: Vignesh C and Hou Zhijie Reviewed-by: Hou Zhijie, Kyotaro Horiguchi, Amit Kapila Backpatch-through: 10, where it was introduced Discussion: https://postgr.es/m/CALDaNm0pF6zeWqCA8TCe2sDuwFAy8fCqba=nHampCKag-qLixg@mail.gmail.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ddfc7299d0a3a41f0c178a8157bd751430428e8a Modified Files -------------- src/backend/commands/publicationcmds.c | 14 +++++++++++++- src/test/regress/expected/publication.out | 15 +++++++++++++++ src/test/regress/sql/publication.sql | 14 ++++++++++++++ 3 files changed, 42 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Invalidate relcache for publications defined for all tables. @ 2021-09-08 06:50 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Amit Kapila @ 2021-09-08 06:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Invalidate relcache for publications defined for all tables. Updates/Deletes on a relation were allowed even without replica identity after we define the publication for all tables. This would later lead to an error on subscribers. The reason was that for such publications we were not invalidating the relcache and the publication information for relations was not getting rebuilt. Similarly, we were not invalidating the relcache after dropping of such publications which will prohibit Updates/Deletes without replica identity even without any publication. Author: Vignesh C and Hou Zhijie Reviewed-by: Hou Zhijie, Kyotaro Horiguchi, Amit Kapila Backpatch-through: 10, where it was introduced Discussion: https://postgr.es/m/CALDaNm0pF6zeWqCA8TCe2sDuwFAy8fCqba=nHampCKag-qLixg@mail.gmail.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2eb09f27db6c5e2e017ac98f208d982486e0edc5 Modified Files -------------- src/backend/commands/publicationcmds.c | 14 +++++++++++++- src/test/regress/expected/publication.out | 15 +++++++++++++++ src/test/regress/sql/publication.sql | 14 ++++++++++++++ 3 files changed, 42 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Invalidate relcache for publications defined for all tables. @ 2021-09-08 06:50 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Amit Kapila @ 2021-09-08 06:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Invalidate relcache for publications defined for all tables. Updates/Deletes on a relation were allowed even without replica identity after we define the publication for all tables. This would later lead to an error on subscribers. The reason was that for such publications we were not invalidating the relcache and the publication information for relations was not getting rebuilt. Similarly, we were not invalidating the relcache after dropping of such publications which will prohibit Updates/Deletes without replica identity even without any publication. Author: Vignesh C and Hou Zhijie Reviewed-by: Hou Zhijie, Kyotaro Horiguchi, Amit Kapila Backpatch-through: 10, where it was introduced Discussion: https://postgr.es/m/CALDaNm0pF6zeWqCA8TCe2sDuwFAy8fCqba=nHampCKag-qLixg@mail.gmail.com Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/96e38fa5e549e9891b0f0dc3baf41e273ad3ede5 Modified Files -------------- src/backend/commands/publicationcmds.c | 12 ++++++++++++ src/test/regress/expected/publication.out | 15 +++++++++++++++ src/test/regress/sql/publication.sql | 14 ++++++++++++++ 3 files changed, 41 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Invalidate relcache for publications defined for all tables. @ 2021-09-08 06:50 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Amit Kapila @ 2021-09-08 06:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Invalidate relcache for publications defined for all tables. Updates/Deletes on a relation were allowed even without replica identity after we define the publication for all tables. This would later lead to an error on subscribers. The reason was that for such publications we were not invalidating the relcache and the publication information for relations was not getting rebuilt. Similarly, we were not invalidating the relcache after dropping of such publications which will prohibit Updates/Deletes without replica identity even without any publication. Author: Vignesh C and Hou Zhijie Reviewed-by: Hou Zhijie, Kyotaro Horiguchi, Amit Kapila Backpatch-through: 10, where it was introduced Discussion: https://postgr.es/m/CALDaNm0pF6zeWqCA8TCe2sDuwFAy8fCqba=nHampCKag-qLixg@mail.gmail.com Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/28cde380c1c02754bc0eebb88e9ec9c4de91a8fb Modified Files -------------- src/backend/commands/publicationcmds.c | 12 ++++++++++++ src/test/regress/expected/publication.out | 15 +++++++++++++++ src/test/regress/sql/publication.sql | 14 ++++++++++++++ 3 files changed, 41 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2021-09-08 06:50 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-09-08 06:50 pgsql: Invalidate relcache for publications defined for all tables. Amit Kapila <akapila@postgresql.org> 2021-09-08 06:50 pgsql: Invalidate relcache for publications defined for all tables. Amit Kapila <akapila@postgresql.org> 2021-09-08 06:50 pgsql: Invalidate relcache for publications defined for all tables. Amit Kapila <akapila@postgresql.org> 2021-09-08 06:50 pgsql: Invalidate relcache for publications defined for all tables. Amit Kapila <akapila@postgresql.org> 2021-09-08 06:50 pgsql: Invalidate relcache for publications defined for all tables. Amit Kapila <akapila@postgresql.org> 2021-09-08 06:50 pgsql: Invalidate relcache for publications defined for all tables. Amit Kapila <akapila@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox