From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Invalidate relcache for publications defined for all tables.
Date: Wed, 08 Sep 2021 06:50:04 +0000
Message-ID: <E1mNrPI-0004pi-HM@gemulon.postgresql.org> (raw)
Invalidate relcache for publications defined for all tables.
Updates/Deletes on a relation were allowed even without replica identity
after we define the publication for all tables. This would later lead to
an error on subscribers. The reason was that for such publications we were
not invalidating the relcache and the publication information for
relations was not getting rebuilt. Similarly, we were not invalidating the
relcache after dropping of such publications which will prohibit
Updates/Deletes without replica identity even without any publication.
Author: Vignesh C and Hou Zhijie
Reviewed-by: Hou Zhijie, Kyotaro Horiguchi, Amit Kapila
Backpatch-through: 10, where it was introduced
Discussion: https://postgr.es/m/CALDaNm0pF6zeWqCA8TCe2sDuwFAy8fCqba=nHampCKag-qLixg@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8bd534274099aabf721ca4baef2e8a3a379d7b02
Modified Files
--------------
src/backend/catalog/dependency.c | 5 ++++-
src/backend/commands/publicationcmds.c | 34 +++++++++++++++++++++++++++++++
src/include/commands/publicationcmds.h | 1 +
src/test/regress/expected/publication.out | 15 ++++++++++++++
src/test/regress/sql/publication.sql | 14 +++++++++++++
5 files changed, 68 insertions(+), 1 deletion(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: akapila@postgresql.org
Subject: Re: pgsql: Invalidate relcache for publications defined for all tables.
In-Reply-To: <E1mNrPI-0004pi-HM@gemulon.postgresql.org>
References: <E1mNrPI-0004pi-HM@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox