pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Disable anonymous record hash support except in special cases
Date: Wed, 08 Sep 2021 08:07:51 +0000
Message-ID: <E1mNscZ-0005U9-4d@gemulon.postgresql.org> (raw)

Disable anonymous record hash support except in special cases

Commit 01e658fa74 added hash support for row types.  This also added
support for hashing anonymous record types, using the same approach
that the type cache uses for comparison support for record types: It
just reports that it works, but it might fail at run time if a
component type doesn't actually support the operation.  We get away
with that for comparison because most types support that.  But some
types don't support hashing, so the current state can result in
failures at run time where the planner chooses hashing over sorting,
whereas that previously worked if only sorting was an option.

We do, however, want the record hashing support for path tracking in
recursive unions, and the SEARCH and CYCLE clauses built on that.  In
that case, hashing is the only plan option.  So enable that, this
commit implements the following approach: The type cache does not
report that hashing is available for the record type.  This undoes
that part of 01e658fa74.  Instead, callers that require hashing no
matter what can override that result themselves.  This patch only
touches the callers to make the aforementioned recursive query cases
work, namely the parse analysis of unions, as well as the hash_array()
function.

Reported-by: Sait Talha Nisanci <sait.nisanci@microsoft.com>
Bug: #17158
Discussion: https://www.postgresql.org/message-id/flat/17158-8a2ba823982537a4%40postgresql.org

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/054adca641ac1279dc8d9b74fda41948ac35e9a9

Modified Files
--------------
src/backend/parser/analyze.c             | 23 ++++++--
src/backend/rewrite/rewriteSearchCycle.c |  6 +--
src/backend/utils/adt/arrayfuncs.c       | 36 ++++++++++++-
src/backend/utils/cache/typcache.c       | 11 ++--
src/include/parser/analyze.h             |  2 +-
src/test/regress/expected/union.out      | 90 ++++++++++++++++++--------------
src/test/regress/sql/union.sql           |  4 +-
7 files changed, 117 insertions(+), 55 deletions(-)



view thread (2+ messages)

Message-ID: <E1mNscZ-0005U9-4d@gemulon.postgresql.org>
Permalink:  ../E1mNscZ-0005U9-4d@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mNscZ-0005U9-4d@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org
  Subject: Re: pgsql: Disable anonymous record hash support except in special cases
  In-Reply-To: <E1mNscZ-0005U9-4d@gemulon.postgresql.org>
  References: <E1mNscZ-0005U9-4d@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox