pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix performance regression from session statistics.
Date: Thu, 16 Sep 2021 09:12:57 +0000
Message-ID: <E1mQnRx-00028d-Ky@gemulon.postgresql.org> (raw)

Fix performance regression from session statistics.

Session statistics, as introduced by 960869da08, had several shortcomings:

- an additional GetCurrentTimestamp() call that also impaired the accuracy of
  the data collected

  This can be avoided by passing the current timestamp we already have in
  pgstat_report_stat().

- an additional statistics UDP packet sent every 500ms

  This is solved by adding the new statistics to PgStat_MsgTabstat.
  This is conceptually ugly, because session statistics are not
  table statistics.  But the struct already contains data unrelated
  to tables, so there is not much damage done.

  Connection and disconnection are reported in separate messages, which
  reduces the number of additional messages to two messages per session and a
  slight increase in PgStat_MsgTabstat size (but the same number of table
  stats fit).

- Session time computation could overflow on systems where long is 32 bit.

Reported-By: Andres Freund <andres@anarazel.de>
Author: Andres Freund <andres@anarazel.de>
Author: Laurenz Albe <laurenz.albe@cybertec.at>
Discussion: https://postgr.es/m/20210801205501.nyxzxoelqoo4x2qc%40alap3.anarazel.de
Backpatch: 14-, where the feature was introduced.

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7890a423470b3a763aa22faf69a44cb6a2df8f0e

Modified Files
--------------
src/backend/postmaster/pgstat.c             | 195 ++++++++++++++++++----------
src/backend/tcop/postgres.c                 |   2 +
src/backend/utils/activity/backend_status.c |   4 +-
src/include/pgstat.h                        |  34 +++--
src/tools/pgindent/typedefs.list            |   3 +-
5 files changed, 158 insertions(+), 80 deletions(-)



view thread (2+ messages)

Message-ID: <E1mQnRx-00028d-Ky@gemulon.postgresql.org>
Permalink:  ../E1mQnRx-00028d-Ky@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mQnRx-00028d-Ky@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: Fix performance regression from session statistics.
  In-Reply-To: <E1mQnRx-00028d-Ky@gemulon.postgresql.org>
  References: <E1mQnRx-00028d-Ky@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox