pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix EXPLAIN to handle SEARCH BREADTH FIRST queries. 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix EXPLAIN to handle SEARCH BREADTH FIRST queries. @ 2021-09-16 14:45 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2021-09-16 14:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix EXPLAIN to handle SEARCH BREADTH FIRST queries. The rewriter transformation for SEARCH BREADTH FIRST produces a FieldSelect on a Var of type RECORD, where the Var references the recursive union's worktable output. EXPLAIN VERBOSE failed to handle this case, because it only expected such Vars to appear in CteScans not WorkTableScans. Fix that, and add some test cases exercising EXPLAIN on SEARCH and CYCLE queries. In principle this oversight is an old bug, but it seems that the case is unreachable without SEARCH BREADTH FIRST, because the parser fails when attempting to create such a reference manually. So for today I'll just patch HEAD/v14. Someday we might find that the code portion of this patch needs to be back-patched further. Per report from Atsushi Torikoshi. Discussion: https://postgr.es/m/5bafa66ad529e11860339565c9e7c166@oss.nttdata.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/3f50b82639637c9908afa2087de7588450aa866b Modified Files -------------- src/backend/utils/adt/ruleutils.c | 40 ++++++++++++-- src/test/regress/expected/with.out | 103 +++++++++++++++++++++++++++++++++++++ src/test/regress/sql/with.sql | 30 +++++++++++ 3 files changed, 170 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix EXPLAIN to handle SEARCH BREADTH FIRST queries. @ 2021-09-16 14:45 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2021-09-16 14:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix EXPLAIN to handle SEARCH BREADTH FIRST queries. The rewriter transformation for SEARCH BREADTH FIRST produces a FieldSelect on a Var of type RECORD, where the Var references the recursive union's worktable output. EXPLAIN VERBOSE failed to handle this case, because it only expected such Vars to appear in CteScans not WorkTableScans. Fix that, and add some test cases exercising EXPLAIN on SEARCH and CYCLE queries. In principle this oversight is an old bug, but it seems that the case is unreachable without SEARCH BREADTH FIRST, because the parser fails when attempting to create such a reference manually. So for today I'll just patch HEAD/v14. Someday we might find that the code portion of this patch needs to be back-patched further. Per report from Atsushi Torikoshi. Discussion: https://postgr.es/m/5bafa66ad529e11860339565c9e7c166@oss.nttdata.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/388726753b638fb9938883bdd057b2ffe6f950f5 Modified Files -------------- src/backend/utils/adt/ruleutils.c | 40 +++++++++++++++++++-- src/test/regress/expected/with.out | 74 +++++++++++++++++++++++++++++++++++++- src/test/regress/sql/with.sql | 24 ++++++++++++- 3 files changed, 133 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2021-09-16 14:45 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-09-16 14:45 pgsql: Fix EXPLAIN to handle SEARCH BREADTH FIRST queries. Tom Lane <tgl@sss.pgh.pa.us> 2021-09-16 14:45 pgsql: Fix EXPLAIN to handle SEARCH BREADTH FIRST queries. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox