pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix EXPLAIN to handle SEARCH BREADTH FIRST queries.
Date: Thu, 16 Sep 2021 14:45:49 +0000
Message-ID: <E1mQse5-00049h-Vc@gemulon.postgresql.org> (raw)

Fix EXPLAIN to handle SEARCH BREADTH FIRST queries.

The rewriter transformation for SEARCH BREADTH FIRST produces a
FieldSelect on a Var of type RECORD, where the Var references the
recursive union's worktable output.  EXPLAIN VERBOSE failed to handle
this case, because it only expected such Vars to appear in CteScans
not WorkTableScans.  Fix that, and add some test cases exercising
EXPLAIN on SEARCH and CYCLE queries.

In principle this oversight is an old bug, but it seems that the
case is unreachable without SEARCH BREADTH FIRST, because the
parser fails when attempting to create such a reference manually.
So for today I'll just patch HEAD/v14.  Someday we might find that
the code portion of this patch needs to be back-patched further.

Per report from Atsushi Torikoshi.

Discussion: https://postgr.es/m/5bafa66ad529e11860339565c9e7c166@oss.nttdata.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/388726753b638fb9938883bdd057b2ffe6f950f5

Modified Files
--------------
src/backend/utils/adt/ruleutils.c  | 40 +++++++++++++++++++--
src/test/regress/expected/with.out | 74 +++++++++++++++++++++++++++++++++++++-
src/test/regress/sql/with.sql      | 24 ++++++++++++-
3 files changed, 133 insertions(+), 5 deletions(-)



view thread (2+ messages)

Message-ID: <E1mQse5-00049h-Vc@gemulon.postgresql.org>
Permalink:  ../E1mQse5-00049h-Vc@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mQse5-00049h-Vc@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix EXPLAIN to handle SEARCH BREADTH FIRST queries.
  In-Reply-To: <E1mQse5-00049h-Vc@gemulon.postgresql.org>
  References: <E1mQse5-00049h-Vc@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox