pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Disable test for postgres -C on Msys
Date: Fri, 17 Sep 2021 00:14:15 +0000
Message-ID: <E1mR1WB-0007Oj-Sh@gemulon.postgresql.org> (raw)

Disable test for postgres -C on Msys

The output generated on Msys is incorrect because of the different way
IPC::Run processes outputs with native Perl (converts natively \r\n to
\n) and Msys perl (\r\n kept as-is), causing this test to fail.

For now, just disable the test to bring the buildfarm to a green state.
I think that the correct long-term solution would be to tweak all the
routines command_checks_* in PostgresNode.pm to handle this output like
psql does when using Msys, by discarding \r automatically before
comparing it.

Per report from jacana and fairywren.  Thanks to Tom Lane for the ping.

Discussion: https://postgr.es/m/1252480.1631829409@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5adb06732d7fac8171609392ea83f18bc8f285f4

Modified Files
--------------
src/bin/pg_checksums/t/002_actions.pl | 20 +++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)



Message-ID: <E1mR1WB-0007Oj-Sh@gemulon.postgresql.org>
Permalink:  ../E1mR1WB-0007Oj-Sh@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mR1WB-0007Oj-Sh@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Disable test for postgres -C on Msys
  In-Reply-To: <E1mR1WB-0007Oj-Sh@gemulon.postgresql.org>
  References: <E1mR1WB-0007Oj-Sh@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox