pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Clarify some errors in pg_receivewal when closing WAL segments
Date: Fri, 17 Sep 2021 06:53:48 +0000
Message-ID: <E1mR7kq-0001Qe-Fi@gemulon.postgresql.org> (raw)

Clarify some errors in pg_receivewal when closing WAL segments

A WAL segment closed during a WAL stream for pg_receivewal would
generate incorrect error messages depending on the context, as the file
name used when referring to a WAL segment ignored partial files or the
compression method used.  In such cases, the error message generated
(failure on close, seek or rename) would not match a physical file
name.  The same code paths are used by pg_basebackup, but it uses no
partial suffix so it is not impacted.

7fbe0c8 has introduced in walmethods.c a callback to get the exact
physical file name used for a given context, this commit makes use of it
to improve those error messages.  This could be extended to more code
paths of pg_basebackup/ in the future, if necessary.

Extracted from a larger patch by the same author.

Author: Georgios Kokolatos
Discussion: https://postgr.es/m/ZCm1J5vfyQ2E6dYvXz8si39HQ2gwxSZ3IpYaVgYa3lUwY88SLapx9EEnOf5uEwrddhx2twG7zYKjVeuP...

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cddcf7842c31b4d07ca75439f6b4ddacaadbbd0d

Modified Files
--------------
src/bin/pg_basebackup/receivelog.c | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)



Message-ID: <E1mR7kq-0001Qe-Fi@gemulon.postgresql.org>
Permalink:  ../E1mR7kq-0001Qe-Fi@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mR7kq-0001Qe-Fi@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Clarify some errors in pg_receivewal when closing WAL segments
  In-Reply-To: <E1mR7kq-0001Qe-Fi@gemulon.postgresql.org>
  References: <E1mR7kq-0001Qe-Fi@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox