pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix pull_varnos to cope with translated PlaceHolderVars.
4+ messages / 1 participants
[nested] [flat]

* pgsql: Fix pull_varnos to cope with translated PlaceHolderVars.
@ 2021-09-17 19:41  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 4+ messages in thread

From: Tom Lane @ 2021-09-17 19:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix pull_varnos to cope with translated PlaceHolderVars.

Commit 55dc86eca changed pull_varnos to use (if possible) the associated
ph_eval_at for a PlaceHolderVar.  I missed a fine point though: we might
be looking at a PHV in the quals or tlist of a child appendrel, in which
case we need to compute a ph_eval_at value that's been translated in the
same way that the PHV itself has been (cf. adjust_appendrel_attrs).
Fortunately, enough info is available in the PlaceHolderInfo to make
such translation possible without additional outside data, so we don't
need another round of uglification of planner APIs.  This is a little
bit complicated, but since it's a hard-to-hit corner case, I'm not much
worried about adding cycles here.

Per report from Jaime Casanova.  Back-patch to v12, like the previous
commit.

Discussion: https://postgr.es/m/20210915230959.GB17635@ahch-to

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a21049fd3f64518c8a7227cf07c56f2543241db2

Modified Files
--------------
src/backend/optimizer/util/var.c   | 41 +++++++++++++++++++++++++++++++++++---
src/test/regress/expected/join.out | 28 ++++++++++++++++++++++++++
src/test/regress/sql/join.sql      | 16 +++++++++++++++
3 files changed, 82 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* pgsql: Fix pull_varnos to cope with translated PlaceHolderVars.
@ 2021-09-17 19:41  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 4+ messages in thread

From: Tom Lane @ 2021-09-17 19:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix pull_varnos to cope with translated PlaceHolderVars.

Commit 55dc86eca changed pull_varnos to use (if possible) the associated
ph_eval_at for a PlaceHolderVar.  I missed a fine point though: we might
be looking at a PHV in the quals or tlist of a child appendrel, in which
case we need to compute a ph_eval_at value that's been translated in the
same way that the PHV itself has been (cf. adjust_appendrel_attrs).
Fortunately, enough info is available in the PlaceHolderInfo to make
such translation possible without additional outside data, so we don't
need another round of uglification of planner APIs.  This is a little
bit complicated, but since it's a hard-to-hit corner case, I'm not much
worried about adding cycles here.

Per report from Jaime Casanova.  Back-patch to v12, like the previous
commit.

Discussion: https://postgr.es/m/20210915230959.GB17635@ahch-to

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4d5b4483db1c6370861ca968edd753ab4dc03f9d

Modified Files
--------------
src/backend/optimizer/util/var.c   | 41 +++++++++++++++++++++++++++++++++++---
src/test/regress/expected/join.out | 28 ++++++++++++++++++++++++++
src/test/regress/sql/join.sql      | 16 +++++++++++++++
3 files changed, 82 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* pgsql: Fix pull_varnos to cope with translated PlaceHolderVars.
@ 2021-09-17 19:41  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 4+ messages in thread

From: Tom Lane @ 2021-09-17 19:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix pull_varnos to cope with translated PlaceHolderVars.

Commit 55dc86eca changed pull_varnos to use (if possible) the associated
ph_eval_at for a PlaceHolderVar.  I missed a fine point though: we might
be looking at a PHV in the quals or tlist of a child appendrel, in which
case we need to compute a ph_eval_at value that's been translated in the
same way that the PHV itself has been (cf. adjust_appendrel_attrs).
Fortunately, enough info is available in the PlaceHolderInfo to make
such translation possible without additional outside data, so we don't
need another round of uglification of planner APIs.  This is a little
bit complicated, but since it's a hard-to-hit corner case, I'm not much
worried about adding cycles here.

Per report from Jaime Casanova.  Back-patch to v12, like the previous
commit.

Discussion: https://postgr.es/m/20210915230959.GB17635@ahch-to

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e0b0d1eab48c85f961a39c263d2074ad11931920

Modified Files
--------------
src/backend/optimizer/util/var.c   | 41 +++++++++++++++++++++++++++++++++++---
src/test/regress/expected/join.out | 28 ++++++++++++++++++++++++++
src/test/regress/sql/join.sql      | 16 +++++++++++++++
3 files changed, 82 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* pgsql: Fix pull_varnos to cope with translated PlaceHolderVars.
@ 2021-09-17 19:41  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 4+ messages in thread

From: Tom Lane @ 2021-09-17 19:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix pull_varnos to cope with translated PlaceHolderVars.

Commit 55dc86eca changed pull_varnos to use (if possible) the associated
ph_eval_at for a PlaceHolderVar.  I missed a fine point though: we might
be looking at a PHV in the quals or tlist of a child appendrel, in which
case we need to compute a ph_eval_at value that's been translated in the
same way that the PHV itself has been (cf. adjust_appendrel_attrs).
Fortunately, enough info is available in the PlaceHolderInfo to make
such translation possible without additional outside data, so we don't
need another round of uglification of planner APIs.  This is a little
bit complicated, but since it's a hard-to-hit corner case, I'm not much
worried about adding cycles here.

Per report from Jaime Casanova.  Back-patch to v12, like the previous
commit.

Discussion: https://postgr.es/m/20210915230959.GB17635@ahch-to

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/febe013cad5992ba8994db309cd1b7d85062c6d3

Modified Files
--------------
src/backend/optimizer/util/var.c   | 41 +++++++++++++++++++++++++++++++++++---
src/test/regress/expected/join.out | 28 ++++++++++++++++++++++++++
src/test/regress/sql/join.sql      | 16 +++++++++++++++
3 files changed, 82 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2021-09-17 19:41 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-09-17 19:41 pgsql: Fix pull_varnos to cope with translated PlaceHolderVars. Tom Lane <tgl@sss.pgh.pa.us>
2021-09-17 19:41 pgsql: Fix pull_varnos to cope with translated PlaceHolderVars. Tom Lane <tgl@sss.pgh.pa.us>
2021-09-17 19:41 pgsql: Fix pull_varnos to cope with translated PlaceHolderVars. Tom Lane <tgl@sss.pgh.pa.us>
2021-09-17 19:41 pgsql: Fix pull_varnos to cope with translated PlaceHolderVars. Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox