pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix pull_varnos to cope with translated PlaceHolderVars.
Date: Fri, 17 Sep 2021 19:41:35 +0000
Message-ID: <E1mRJjr-00063g-SN@gemulon.postgresql.org> (raw)

Fix pull_varnos to cope with translated PlaceHolderVars.

Commit 55dc86eca changed pull_varnos to use (if possible) the associated
ph_eval_at for a PlaceHolderVar.  I missed a fine point though: we might
be looking at a PHV in the quals or tlist of a child appendrel, in which
case we need to compute a ph_eval_at value that's been translated in the
same way that the PHV itself has been (cf. adjust_appendrel_attrs).
Fortunately, enough info is available in the PlaceHolderInfo to make
such translation possible without additional outside data, so we don't
need another round of uglification of planner APIs.  This is a little
bit complicated, but since it's a hard-to-hit corner case, I'm not much
worried about adding cycles here.

Per report from Jaime Casanova.  Back-patch to v12, like the previous
commit.

Discussion: https://postgr.es/m/20210915230959.GB17635@ahch-to

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e0b0d1eab48c85f961a39c263d2074ad11931920

Modified Files
--------------
src/backend/optimizer/util/var.c   | 41 +++++++++++++++++++++++++++++++++++---
src/test/regress/expected/join.out | 28 ++++++++++++++++++++++++++
src/test/regress/sql/join.sql      | 16 +++++++++++++++
3 files changed, 82 insertions(+), 3 deletions(-)



view thread (4+ messages)  latest in thread

Message-ID: <E1mRJjr-00063g-SN@gemulon.postgresql.org>
Permalink:  ../E1mRJjr-00063g-SN@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mRJjr-00063g-SN@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix pull_varnos to cope with translated PlaceHolderVars.
  In-Reply-To: <E1mRJjr-00063g-SN@gemulon.postgresql.org>
  References: <E1mRJjr-00063g-SN@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox