pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Disallow extended statistics on system columns
Date: Sun, 19 Sep 2021 23:01:15 +0000
Message-ID: <E1mS5oB-00074r-7W@gemulon.postgresql.org> (raw)

Disallow extended statistics on system columns

Since introduction of extended statistics, we've disallowed references
to system columns. So for example

    CREATE STATISTICS s ON ctid FROM t;

would fail. But with extended statistics on expressions, it was possible
to work around this limitation quite easily

    CREATE STATISTICS s ON (ctid::text) FROM t;

This is an oversight in a4d75c86bf, fixed by adding a simple check.
Backpatch to PostgreSQL 14, where support for extended statistics on
expressions was introduced.

Backpatch-through: 14
Discussion: https://postgr.es/m/20210816013255.GS10479%40telsasoft.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/66061077155d68463ec00604ba7d6f0ae69716e8

Modified Files
--------------
src/backend/commands/statscmds.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)



view thread (2+ messages)

Message-ID: <E1mS5oB-00074r-7W@gemulon.postgresql.org>
Permalink:  ../E1mS5oB-00074r-7W@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mS5oB-00074r-7W@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tomas.vondra@postgresql.org
  Subject: Re: pgsql: Disallow extended statistics on system columns
  In-Reply-To: <E1mS5oB-00074r-7W@gemulon.postgresql.org>
  References: <E1mS5oB-00074r-7W@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox