pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't elide casting to typmod -1.
Date: Mon, 20 Sep 2021 15:49:30 +0000
Message-ID: <E1mSLXu-000500-PP@gemulon.postgresql.org> (raw)

Don't elide casting to typmod -1.

Casting a value that's already of a type with a specific typmod
to an unspecified typmod doesn't do anything so far as run-time
behavior is concerned.  However, it really ought to change the
exposed type of the expression to match.  Up to now,
coerce_type_typmod hasn't bothered with that, which creates gotchas
in contexts such as recursive unions.  If for example one side of
the union is numeric(18,3), but it needs to be plain numeric to
match the other side, there's no direct way to express that.

This is easy enough to fix, by inserting a RelabelType to update the
exposed type of the expression.  However, it's a bit nervous-making
to change this behavior, because it's stood for a really long time.
But no complaints have emerged about 14beta3, so go ahead and
back-patch.

Back-patch of 5c056b0c2 into previous supported branches.

Discussion: https://postgr.es/m/CABNQVagu3bZGqiTjb31a8D5Od3fUMs7Oh3gmZMQZVHZ=uWWWfQ@mail.gmail.com
Discussion: https://postgr.es/m/1488389.1631984807@sss.pgh.pa.us

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/dede1439978120d2196e0d3963bb809a8b262e5b

Modified Files
--------------
src/backend/parser/parse_coerce.c         | 26 ++++++++++++++--------
src/test/regress/expected/expressions.out | 37 +++++++++++++++++++++++++++++++
src/test/regress/sql/expressions.sql      | 20 +++++++++++++++++
3 files changed, 74 insertions(+), 9 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1mSLXu-000500-PP@gemulon.postgresql.org>
Permalink:  ../E1mSLXu-000500-PP@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mSLXu-000500-PP@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Don't elide casting to typmod -1.
  In-Reply-To: <E1mSLXu-000500-PP@gemulon.postgresql.org>
  References: <E1mSLXu-000500-PP@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox