pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove overzealous index deletion assertion.
Date: Mon, 20 Sep 2021 21:29:31 +0000
Message-ID: <E1mSQqx-000715-Bo@gemulon.postgresql.org> (raw)

Remove overzealous index deletion assertion.

A broken HOT chain is not an unexpected condition, even when the offset
number points past the end of the page's line pointer array.
heap_prune_chain() does not (and never has) treated this condition as
unexpected, so derivative code in heap_index_delete_tuples() shouldn't
do so either.

Oversight in commit 4228817449.

The assertion can probably only fail on Postgres 14 and master.  Earlier
releases don't have commit 3c3b8a4b, which taught VACUUM to truncate the
line pointer array of heap pages.  Backpatch all the same, just to be
consistent.

Author: Peter Geoghegan <pg@bowt.ie>
Reported-By: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/17197-9438f31f46705182@postgresql.org
Backpatch: 12-, just like commit 4228817449.

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a1708ab652eaef3e9405d5119721a9a4ecb6fcbd

Modified Files
--------------
src/backend/access/heap/heapam.c | 3 ---
1 file changed, 3 deletions(-)



view thread (4+ messages)  latest in thread

Message-ID: <E1mSQqx-000715-Bo@gemulon.postgresql.org>
Permalink:  ../E1mSQqx-000715-Bo@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mSQqx-000715-Bo@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: pg@bowt.ie
  Subject: Re: pgsql: Remove overzealous index deletion assertion.
  In-Reply-To: <E1mSQqx-000715-Bo@gemulon.postgresql.org>
  References: <E1mSQqx-000715-Bo@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox