pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Remove overzealous index deletion assertion.
4+ messages / 1 participants
[nested] [flat]

* pgsql: Remove overzealous index deletion assertion.
@ 2021-09-20 21:29 Peter Geoghegan <pg@bowt.ie>
  0 siblings, 0 replies; 4+ messages in thread

From: Peter Geoghegan @ 2021-09-20 21:29 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove overzealous index deletion assertion.

A broken HOT chain is not an unexpected condition, even when the offset
number points past the end of the page's line pointer array.
heap_prune_chain() does not (and never has) treated this condition as
unexpected, so derivative code in heap_index_delete_tuples() shouldn't
do so either.

Oversight in commit 4228817449.

The assertion can probably only fail on Postgres 14 and master.  Earlier
releases don't have commit 3c3b8a4b, which taught VACUUM to truncate the
line pointer array of heap pages.  Backpatch all the same, just to be
consistent.

Author: Peter Geoghegan <pg@bowt.ie>
Reported-By: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/17197-9438f31f46705182@postgresql.org
Backpatch: 12-, just like commit 4228817449.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5e6716cde5749aea506dd3f30b099b6e9b4c5af8

Modified Files
--------------
src/backend/access/heap/heapam.c | 3 ---
1 file changed, 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* pgsql: Remove overzealous index deletion assertion.
@ 2021-09-20 21:29 Peter Geoghegan <pg@bowt.ie>
  0 siblings, 0 replies; 4+ messages in thread

From: Peter Geoghegan @ 2021-09-20 21:29 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove overzealous index deletion assertion.

A broken HOT chain is not an unexpected condition, even when the offset
number points past the end of the page's line pointer array.
heap_prune_chain() does not (and never has) treated this condition as
unexpected, so derivative code in heap_index_delete_tuples() shouldn't
do so either.

Oversight in commit 4228817449.

The assertion can probably only fail on Postgres 14 and master.  Earlier
releases don't have commit 3c3b8a4b, which taught VACUUM to truncate the
line pointer array of heap pages.  Backpatch all the same, just to be
consistent.

Author: Peter Geoghegan <pg@bowt.ie>
Reported-By: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/17197-9438f31f46705182@postgresql.org
Backpatch: 12-, just like commit 4228817449.

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/955a6a893498a5d3af544d9c0b1c292b19ec1690

Modified Files
--------------
src/backend/access/heap/heapam.c | 3 ---
1 file changed, 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* pgsql: Remove overzealous index deletion assertion.
@ 2021-09-20 21:29 Peter Geoghegan <pg@bowt.ie>
  0 siblings, 0 replies; 4+ messages in thread

From: Peter Geoghegan @ 2021-09-20 21:29 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove overzealous index deletion assertion.

A broken HOT chain is not an unexpected condition, even when the offset
number points past the end of the page's line pointer array.
heap_prune_chain() does not (and never has) treated this condition as
unexpected, so derivative code in heap_index_delete_tuples() shouldn't
do so either.

Oversight in commit 4228817449.

The assertion can probably only fail on Postgres 14 and master.  Earlier
releases don't have commit 3c3b8a4b, which taught VACUUM to truncate the
line pointer array of heap pages.  Backpatch all the same, just to be
consistent.

Author: Peter Geoghegan <pg@bowt.ie>
Reported-By: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/17197-9438f31f46705182@postgresql.org
Backpatch: 12-, just like commit 4228817449.

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a1708ab652eaef3e9405d5119721a9a4ecb6fcbd

Modified Files
--------------
src/backend/access/heap/heapam.c | 3 ---
1 file changed, 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* pgsql: Remove overzealous index deletion assertion.
@ 2021-09-20 21:29 Peter Geoghegan <pg@bowt.ie>
  0 siblings, 0 replies; 4+ messages in thread

From: Peter Geoghegan @ 2021-09-20 21:29 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove overzealous index deletion assertion.

A broken HOT chain is not an unexpected condition, even when the offset
number points past the end of the page's line pointer array.
heap_prune_chain() does not (and never has) treated this condition as
unexpected, so derivative code in heap_index_delete_tuples() shouldn't
do so either.

Oversight in commit 4228817449.

The assertion can probably only fail on Postgres 14 and master.  Earlier
releases don't have commit 3c3b8a4b, which taught VACUUM to truncate the
line pointer array of heap pages.  Backpatch all the same, just to be
consistent.

Author: Peter Geoghegan <pg@bowt.ie>
Reported-By: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/17197-9438f31f46705182@postgresql.org
Backpatch: 12-, just like commit 4228817449.

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cd35d3909bf1665b688eac691a0f2087c55610de

Modified Files
--------------
src/backend/access/heap/heapam.c | 3 ---
1 file changed, 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2021-09-20 21:29 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-09-20 21:29 pgsql: Remove overzealous index deletion assertion. Peter Geoghegan <pg@bowt.ie>
2021-09-20 21:29 pgsql: Remove overzealous index deletion assertion. Peter Geoghegan <pg@bowt.ie>
2021-09-20 21:29 pgsql: Remove overzealous index deletion assertion. Peter Geoghegan <pg@bowt.ie>
2021-09-20 21:29 pgsql: Remove overzealous index deletion assertion. Peter Geoghegan <pg@bowt.ie>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox