pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix places in TestLib.pm in need of adaptation to the output of 7+ messages / 1 participants [nested] [flat]
* pgsql: Fix places in TestLib.pm in need of adaptation to the output of @ 2021-09-21 23:45 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2021-09-21 23:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix places in TestLib.pm in need of adaptation to the output of Msys perl Contrary to the output of native perl, Msys perl generates outputs with CRLFs characters. There are already places in the TAP code where CRLFs (\r\n) are automatically converted to LF (\n) on Msys, but we missed a couple of places when running commands and using their output for comparison, that would lead to failures. This problem has been found thanks to the test added in 5adb067 using TestLib::command_checks_all(), but after a closer look more code paths were missing a filter. This is backpatched all the way down to prevent any surprises if a new test is introduced in stable branches. Reviewed-by: Andrew Dunstan, Álvaro Herrera Discussion: https://postgr.es/m/1252480.1631829409@sss.pgh.pa.us Backpatch-through: 9.6 Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1b6d1ead3bfbf1771d2cf8fd975f980a16211348 Modified Files -------------- src/test/perl/TestLib.pm | 4 ++++ 1 file changed, 4 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix places in TestLib.pm in need of adaptation to the output of @ 2021-09-21 23:45 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2021-09-21 23:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix places in TestLib.pm in need of adaptation to the output of Msys perl Contrary to the output of native perl, Msys perl generates outputs with CRLFs characters. There are already places in the TAP code where CRLFs (\r\n) are automatically converted to LF (\n) on Msys, but we missed a couple of places when running commands and using their output for comparison, that would lead to failures. This problem has been found thanks to the test added in 5adb067 using TestLib::command_checks_all(), but after a closer look more code paths were missing a filter. This is backpatched all the way down to prevent any surprises if a new test is introduced in stable branches. Reviewed-by: Andrew Dunstan, Álvaro Herrera Discussion: https://postgr.es/m/1252480.1631829409@sss.pgh.pa.us Backpatch-through: 9.6 Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/782480fe757f9bbce8d6224585a02172c2c408bb Modified Files -------------- src/test/perl/TestLib.pm | 2 ++ 1 file changed, 2 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix places in TestLib.pm in need of adaptation to the output of @ 2021-09-21 23:45 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2021-09-21 23:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix places in TestLib.pm in need of adaptation to the output of Msys perl Contrary to the output of native perl, Msys perl generates outputs with CRLFs characters. There are already places in the TAP code where CRLFs (\r\n) are automatically converted to LF (\n) on Msys, but we missed a couple of places when running commands and using their output for comparison, that would lead to failures. This problem has been found thanks to the test added in 5adb067 using TestLib::command_checks_all(), but after a closer look more code paths were missing a filter. This is backpatched all the way down to prevent any surprises if a new test is introduced in stable branches. Reviewed-by: Andrew Dunstan, Álvaro Herrera Discussion: https://postgr.es/m/1252480.1631829409@sss.pgh.pa.us Backpatch-through: 9.6 Branch ------ REL9_6_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/404061515cd54a4bbb0447355ca4420411c7bff2 Modified Files -------------- src/test/perl/TestLib.pm | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix places in TestLib.pm in need of adaptation to the output of @ 2021-09-21 23:45 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2021-09-21 23:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix places in TestLib.pm in need of adaptation to the output of Msys perl Contrary to the output of native perl, Msys perl generates outputs with CRLFs characters. There are already places in the TAP code where CRLFs (\r\n) are automatically converted to LF (\n) on Msys, but we missed a couple of places when running commands and using their output for comparison, that would lead to failures. This problem has been found thanks to the test added in 5adb067 using TestLib::command_checks_all(), but after a closer look more code paths were missing a filter. This is backpatched all the way down to prevent any surprises if a new test is introduced in stable branches. Reviewed-by: Andrew Dunstan, Álvaro Herrera Discussion: https://postgr.es/m/1252480.1631829409@sss.pgh.pa.us Backpatch-through: 9.6 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/0d91c52a8fc71bfe5664a13368e42e1dabc5fe78 Modified Files -------------- src/test/perl/TestLib.pm | 5 +++++ 1 file changed, 5 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix places in TestLib.pm in need of adaptation to the output of @ 2021-09-21 23:45 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2021-09-21 23:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix places in TestLib.pm in need of adaptation to the output of Msys perl Contrary to the output of native perl, Msys perl generates outputs with CRLFs characters. There are already places in the TAP code where CRLFs (\r\n) are automatically converted to LF (\n) on Msys, but we missed a couple of places when running commands and using their output for comparison, that would lead to failures. This problem has been found thanks to the test added in 5adb067 using TestLib::command_checks_all(), but after a closer look more code paths were missing a filter. This is backpatched all the way down to prevent any surprises if a new test is introduced in stable branches. Reviewed-by: Andrew Dunstan, Álvaro Herrera Discussion: https://postgr.es/m/1252480.1631829409@sss.pgh.pa.us Backpatch-through: 9.6 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/90251ff199858844fa450ba9614092c06c67fc4f Modified Files -------------- src/test/perl/TestLib.pm | 5 +++++ 1 file changed, 5 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix places in TestLib.pm in need of adaptation to the output of @ 2021-09-21 23:45 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2021-09-21 23:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix places in TestLib.pm in need of adaptation to the output of Msys perl Contrary to the output of native perl, Msys perl generates outputs with CRLFs characters. There are already places in the TAP code where CRLFs (\r\n) are automatically converted to LF (\n) on Msys, but we missed a couple of places when running commands and using their output for comparison, that would lead to failures. This problem has been found thanks to the test added in 5adb067 using TestLib::command_checks_all(), but after a closer look more code paths were missing a filter. This is backpatched all the way down to prevent any surprises if a new test is introduced in stable branches. Reviewed-by: Andrew Dunstan, Álvaro Herrera Discussion: https://postgr.es/m/1252480.1631829409@sss.pgh.pa.us Backpatch-through: 9.6 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/583e15af9976f8905e2b27f985d619e758270e16 Modified Files -------------- src/test/perl/TestLib.pm | 5 +++++ 1 file changed, 5 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix places in TestLib.pm in need of adaptation to the output of @ 2021-09-21 23:45 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2021-09-21 23:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix places in TestLib.pm in need of adaptation to the output of Msys perl Contrary to the output of native perl, Msys perl generates outputs with CRLFs characters. There are already places in the TAP code where CRLFs (\r\n) are automatically converted to LF (\n) on Msys, but we missed a couple of places when running commands and using their output for comparison, that would lead to failures. This problem has been found thanks to the test added in 5adb067 using TestLib::command_checks_all(), but after a closer look more code paths were missing a filter. This is backpatched all the way down to prevent any surprises if a new test is introduced in stable branches. Reviewed-by: Andrew Dunstan, Álvaro Herrera Discussion: https://postgr.es/m/1252480.1631829409@sss.pgh.pa.us Backpatch-through: 9.6 Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/76001de031a562a0f350daae381196fa44576eb3 Modified Files -------------- src/test/perl/TestLib.pm | 5 +++++ 1 file changed, 5 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2021-09-21 23:45 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-09-21 23:45 pgsql: Fix places in TestLib.pm in need of adaptation to the output of Michael Paquier <michael@paquier.xyz> 2021-09-21 23:45 pgsql: Fix places in TestLib.pm in need of adaptation to the output of Michael Paquier <michael@paquier.xyz> 2021-09-21 23:45 pgsql: Fix places in TestLib.pm in need of adaptation to the output of Michael Paquier <michael@paquier.xyz> 2021-09-21 23:45 pgsql: Fix places in TestLib.pm in need of adaptation to the output of Michael Paquier <michael@paquier.xyz> 2021-09-21 23:45 pgsql: Fix places in TestLib.pm in need of adaptation to the output of Michael Paquier <michael@paquier.xyz> 2021-09-21 23:45 pgsql: Fix places in TestLib.pm in need of adaptation to the output of Michael Paquier <michael@paquier.xyz> 2021-09-21 23:45 pgsql: Fix places in TestLib.pm in need of adaptation to the output of Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox